Skip to content

Commit 0daf5cb

Browse files
Jiri Olsarostedt
authored andcommitted
ftrace/samples: Add missing prototypes direct functions
There's another compilation fail (first here [1]) reported by kernel test robot for W=1 clang build: >> samples/ftrace/ftrace-direct-multi-modify.c:7:6: warning: no previous prototype for function 'my_direct_func1' [-Wmissing-prototypes] void my_direct_func1(unsigned long ip) Direct functions in ftrace direct sample modules need to have prototypes defined. They are already global in order to be visible for the inline assembly, so there's no problem. The kernel test robot reported just error for ftrace-direct-multi-modify, but I got same errors also for the rest of the modules touched by this patch. [1] 67d4f6e ftrace/samples: Add missing prototype for my_direct_func Link: https://lkml.kernel.org/r/[email protected] Reported-by: kernel test robot <[email protected]> Fixes: e1067a0 ("ftrace/samples: Add module to test multi direct modify interface") Fixes: ae0cc3b ("ftrace/samples: Add a sample module that implements modify_ftrace_direct()") Fixes: 156473a ("ftrace: Add another example of register_ftrace_direct() use case") Fixes: b06457c ("ftrace: Add sample module that uses register_ftrace_direct()") Signed-off-by: Jiri Olsa <[email protected]> Signed-off-by: Steven Rostedt <[email protected]>
1 parent c24be24 commit 0daf5cb

File tree

4 files changed

+11
-0
lines changed

4 files changed

+11
-0
lines changed

samples/ftrace/ftrace-direct-modify.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,9 @@
44
#include <linux/ftrace.h>
55
#include <asm/asm-offsets.h>
66

7+
extern void my_direct_func1(void);
8+
extern void my_direct_func2(void);
9+
710
void my_direct_func1(void)
811
{
912
trace_printk("my direct func1\n");

samples/ftrace/ftrace-direct-multi-modify.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,9 @@
44
#include <linux/ftrace.h>
55
#include <asm/asm-offsets.h>
66

7+
extern void my_direct_func1(unsigned long ip);
8+
extern void my_direct_func2(unsigned long ip);
9+
710
void my_direct_func1(unsigned long ip)
811
{
912
trace_printk("my direct func1 ip %lx\n", ip);

samples/ftrace/ftrace-direct-too.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,9 @@
55
#include <linux/ftrace.h>
66
#include <asm/asm-offsets.h>
77

8+
extern void my_direct_func(struct vm_area_struct *vma,
9+
unsigned long address, unsigned int flags);
10+
811
void my_direct_func(struct vm_area_struct *vma,
912
unsigned long address, unsigned int flags)
1013
{

samples/ftrace/ftrace-direct.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@
55
#include <linux/ftrace.h>
66
#include <asm/asm-offsets.h>
77

8+
extern void my_direct_func(struct task_struct *p);
9+
810
void my_direct_func(struct task_struct *p)
911
{
1012
trace_printk("waking up %s-%d\n", p->comm, p->pid);

0 commit comments

Comments
 (0)