Skip to content

Commit 0dcdf84

Browse files
committed
drm/amdgpu: fix error checking in amdgpu_read_mm_registers for soc15
Properly skip non-existent registers as well. Bug: https://gitlab.freedesktop.org/drm/amd/-/issues/2442 Reviewed-by: Hawking Zhang <[email protected]> Reviewed-by: Evan Quan <[email protected]> Signed-off-by: Alex Deucher <[email protected]> Cc: [email protected]
1 parent 8879ec6 commit 0dcdf84

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

drivers/gpu/drm/amd/amdgpu/soc15.c

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -439,8 +439,9 @@ static int soc15_read_register(struct amdgpu_device *adev, u32 se_num,
439439
*value = 0;
440440
for (i = 0; i < ARRAY_SIZE(soc15_allowed_read_registers); i++) {
441441
en = &soc15_allowed_read_registers[i];
442-
if (adev->reg_offset[en->hwip][en->inst] &&
443-
reg_offset != (adev->reg_offset[en->hwip][en->inst][en->seg]
442+
if (!adev->reg_offset[en->hwip][en->inst])
443+
continue;
444+
else if (reg_offset != (adev->reg_offset[en->hwip][en->inst][en->seg]
444445
+ en->reg_offset))
445446
continue;
446447

0 commit comments

Comments
 (0)