sysctl: set variable key_sysctls storage-class-specifier to static

Tom Rix · jarkkojs · commit 0de030b30823 · 2023-08-07T17:55:54.000Z
smatch reports
security/keys/sysctl.c:12:18: warning: symbol
  'key_sysctls' was not declared. Should it be static?

This variable is only used in its defining file, so it should be static.

Signed-off-by: Tom Rix &lt;trix@redhat.com&gt;
Signed-off-by: Jarkko Sakkinen &lt;jarkko@kernel.org&gt;
diff --git a/security/keys/sysctl.c b/security/keys/sysctl.c
@@ -9,7 +9,7 @@
 #include <linux/sysctl.h>
 #include "internal.h"
 
-struct ctl_table key_sysctls[] = {
+static struct ctl_table key_sysctls[] = {
 	{
 		.procname = "maxkeys",
 		.data = &key_quota_maxkeys,

Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,7 @@`
`9`	`9`	`#include <linux/sysctl.h>`
`10`	`10`	`#include "internal.h"`
`11`	`11`
`12`		`-struct ctl_table key_sysctls[] = {`
	`12`	`+static struct ctl_table key_sysctls[] = {`
`13`	`13`	`{`
`14`	`14`	`.procname = "maxkeys",`
`15`	`15`	`.data = &key_quota_maxkeys,`