Skip to content

Commit 0df8ef6

Browse files
jnikulaalexdeucher
authored andcommitted
drm/amdgpu: drop redundant W=1 warnings from Makefile
Since commit a61ddb4 ("drm: enable (most) W=1 warnings by default across the subsystem"), most of the extra warnings in the driver Makefile are redundant. Remove them. Note that -Wmissing-declarations and -Wmissing-prototypes are always enabled by default in scripts/Makefile.extrawarn. Reviewed-by: Hamza Mahfooz <[email protected]> Signed-off-by: Jani Nikula <[email protected]> Signed-off-by: Hamza Mahfooz <[email protected]> Signed-off-by: Alex Deucher <[email protected]>
1 parent 7ccde2e commit 0df8ef6

File tree

1 file changed

+1
-17
lines changed

1 file changed

+1
-17
lines changed

drivers/gpu/drm/amd/amdgpu/Makefile

Lines changed: 1 addition & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -39,23 +39,7 @@ ccflags-y := -I$(FULL_AMD_PATH)/include/asic_reg \
3939
-I$(FULL_AMD_DISPLAY_PATH)/amdgpu_dm \
4040
-I$(FULL_AMD_PATH)/amdkfd
4141

42-
subdir-ccflags-y := -Wextra
43-
subdir-ccflags-y += -Wunused
44-
subdir-ccflags-y += -Wmissing-prototypes
45-
subdir-ccflags-y += -Wmissing-declarations
46-
subdir-ccflags-y += -Wmissing-include-dirs
47-
subdir-ccflags-y += -Wold-style-definition
48-
subdir-ccflags-y += -Wmissing-format-attribute
49-
# Need this to avoid recursive variable evaluation issues
50-
cond-flags := $(call cc-option, -Wunused-but-set-variable) \
51-
$(call cc-option, -Wunused-const-variable) \
52-
$(call cc-option, -Wstringop-truncation) \
53-
$(call cc-option, -Wpacked-not-aligned)
54-
subdir-ccflags-y += $(cond-flags)
55-
subdir-ccflags-y += -Wno-unused-parameter
56-
subdir-ccflags-y += -Wno-type-limits
57-
subdir-ccflags-y += -Wno-sign-compare
58-
subdir-ccflags-y += -Wno-missing-field-initializers
42+
# Locally disable W=1 warnings enabled in drm subsystem Makefile
5943
subdir-ccflags-y += -Wno-override-init
6044
subdir-ccflags-$(CONFIG_DRM_AMDGPU_WERROR) += -Werror
6145

0 commit comments

Comments
 (0)