Skip to content

Commit 0e1aa5b

Browse files
melverKAGA-KOKO
authored andcommitted
kcsan: Restrict supported compilers
The first version of Clang that supports -tsan-distinguish-volatile will be able to support KCSAN. The first Clang release to do so, will be Clang 11. This is due to satisfying all the following requirements: 1. Never emit calls to __tsan_func_{entry,exit}. 2. __no_kcsan functions should not call anything, not even kcsan_{enable,disable}_current(), when using __{READ,WRITE}_ONCE => Requires leaving them plain! 3. Support atomic_{read,set}*() with KCSAN, which rely on arch_atomic_{read,set}*() using __{READ,WRITE}_ONCE() => Because of #2, rely on Clang 11's -tsan-distinguish-volatile support. We will double-instrument atomic_{read,set}*(), but that's reasonable given it's still lower cost than the data_race() variant due to avoiding 2 extra calls (kcsan_{en,dis}able_current() calls). 4. __always_inline functions inlined into __no_kcsan functions are never instrumented. 5. __always_inline functions inlined into instrumented functions are instrumented. 6. __no_kcsan_or_inline functions may be inlined into __no_kcsan functions => Implies leaving 'noinline' off of __no_kcsan_or_inline. 7. Because of #6, __no_kcsan and __no_kcsan_or_inline functions should never be spuriously inlined into instrumented functions, causing the accesses of the __no_kcsan function to be instrumented. Older versions of Clang do not satisfy #3. The latest GCC currently doesn't support at least #1, #3, and #7. Signed-off-by: Marco Elver <[email protected]> Signed-off-by: Borislav Petkov <[email protected]> Signed-off-by: Thomas Gleixner <[email protected]> Acked-by: Peter Zijlstra (Intel) <[email protected]> Acked-by: Will Deacon <[email protected]> Link: https://lkml.kernel.org/r/CANpmjNMTsY_8241bS7=XAfqvZHFLrVEkv_uM4aDUWE_kh3Rvbw@mail.gmail.com Link: https://lkml.kernel.org/r/[email protected]
1 parent 17168f5 commit 0e1aa5b

File tree

1 file changed

+8
-1
lines changed

1 file changed

+8
-1
lines changed

lib/Kconfig.kcsan

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,12 @@
33
config HAVE_ARCH_KCSAN
44
bool
55

6+
config HAVE_KCSAN_COMPILER
7+
def_bool CC_IS_CLANG && $(cc-option,-fsanitize=thread -mllvm -tsan-distinguish-volatile=1)
8+
help
9+
For the list of compilers that support KCSAN, please see
10+
<file:Documentation/dev-tools/kcsan.rst>.
11+
612
config KCSAN_KCOV_BROKEN
713
def_bool KCOV && CC_HAS_SANCOV_TRACE_PC
814
depends on CC_IS_CLANG
@@ -15,7 +21,8 @@ config KCSAN_KCOV_BROKEN
1521

1622
menuconfig KCSAN
1723
bool "KCSAN: dynamic data race detector"
18-
depends on HAVE_ARCH_KCSAN && DEBUG_KERNEL && !KASAN
24+
depends on HAVE_ARCH_KCSAN && HAVE_KCSAN_COMPILER
25+
depends on DEBUG_KERNEL && !KASAN
1926
depends on !KCSAN_KCOV_BROKEN
2027
select STACKTRACE
2128
help

0 commit comments

Comments
 (0)