Skip to content

Commit 0e62ea3

Browse files
author
Gao Xiang
committed
erofs: remove WQ_CPU_INTENSIVE flag from unbound wq's
The documentation [1] says that WQ_CPU_INTENSIVE is "meaningless" for unbound wq. I remove this flag from places where unbound queue is allocated. This is supposed to improve code readability. [1] https://www.kernel.org/doc/html/latest/core-api/workqueue.html#flags Signed-off-by: Maksym Planeta <[email protected]> [Gao Xiang: since the original treewide patch [2] hasn't been merged yet, handling the EROFS part only for the next cycle. ] [2] https://lore.kernel.org/r/[email protected] Link: https://lore.kernel.org/r/[email protected] Reviewed-by: Chao Yu <[email protected]> Signed-off-by: Gao Xiang <[email protected]>
1 parent ee4bf86 commit 0e62ea3

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

fs/erofs/zdata.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,13 +43,13 @@ void z_erofs_exit_zip_subsystem(void)
4343
static inline int z_erofs_init_workqueue(void)
4444
{
4545
const unsigned int onlinecpus = num_possible_cpus();
46-
const unsigned int flags = WQ_UNBOUND | WQ_HIGHPRI | WQ_CPU_INTENSIVE;
4746

4847
/*
4948
* no need to spawn too many threads, limiting threads could minimum
5049
* scheduling overhead, perhaps per-CPU threads should be better?
5150
*/
52-
z_erofs_workqueue = alloc_workqueue("erofs_unzipd", flags,
51+
z_erofs_workqueue = alloc_workqueue("erofs_unzipd",
52+
WQ_UNBOUND | WQ_HIGHPRI,
5353
onlinecpus + onlinecpus / 4);
5454
return z_erofs_workqueue ? 0 : -ENOMEM;
5555
}

0 commit comments

Comments
 (0)