Skip to content

Commit 0e91506

Browse files
jwrdegoedelinusw
authored andcommitted
gpiolib: acpi: Add quirk to ignore EC wakeups on HP x2 10 BYT + AXP288 model
Commit aa23ca3 ("gpiolib: acpi: Add honor_wakeup module-option + quirk mechanism") was added to deal with spurious wakeups on one specific model of the HP x2 10 series. In the mean time I have learned that there are at least 3 different HP x2 10 models: Bay Trail SoC + AXP288 PMIC Cherry Trail SoC + AXP288 PMIC Cherry Trail SoC + TI PMIC And the original quirk is only correct for (and only matches the) Cherry Trail SoC + TI PMIC model. The Bay Trail SoC + AXP288 PMIC model has different DMI strings, has the external EC interrupt on a different GPIO pin and only needs to ignore wakeups on the EC interrupt, the INT0002 device works fine on this model. This commit adds an extra DMI based quirk for the HP x2 10 BYT + AXP288 model, ignoring wakeups for ACPI GPIO events on the EC interrupt pin on this model. This fixes spurious wakeups from suspend on this model. Fixes: aa23ca3 ("gpiolib: acpi: Add honor_wakeup module-option + quirk mechanism") Signed-off-by: Hans de Goede <[email protected]> Link: https://lore.kernel.org/r/[email protected] Acked-by: Mika Westerberg <[email protected]> Signed-off-by: Linus Walleij <[email protected]>
1 parent 2ccb21f commit 0e91506

File tree

1 file changed

+15
-0
lines changed

1 file changed

+15
-0
lines changed

drivers/gpio/gpiolib-acpi.c

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1422,6 +1422,21 @@ static const struct dmi_system_id gpiolib_acpi_quirks[] = {
14221422
.ignore_wake = "INT33FF:01@0,INT0002:00@2",
14231423
},
14241424
},
1425+
{
1426+
/*
1427+
* HP X2 10 models with Bay Trail SoC + AXP288 PMIC use an
1428+
* external embedded-controller connected via I2C + an ACPI GPIO
1429+
* event handler on INT33FC:02 pin 28, causing spurious wakeups.
1430+
*/
1431+
.matches = {
1432+
DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"),
1433+
DMI_MATCH(DMI_PRODUCT_NAME, "HP Pavilion x2 Detachable"),
1434+
DMI_MATCH(DMI_BOARD_NAME, "815D"),
1435+
},
1436+
.driver_data = &(struct acpi_gpiolib_dmi_quirk) {
1437+
.ignore_wake = "INT33FC:02@28",
1438+
},
1439+
},
14251440
{} /* Terminating entry */
14261441
};
14271442

0 commit comments

Comments
 (0)