vfio: avoid possible overflow in vfio_iommu_type1_pin_pages

yanzhao56 · awilliam · commit 0ea971f8dcd6 · 2020-04-20T12:40:16.000-06:00
add parentheses to avoid possible vaddr overflow. Fixes: a54eb55 ("vfio iommu type1: Add support for mediated devices") Signed-off-by: Yan Zhao <yan.y.zhao@intel.com> Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
diff --git a/drivers/vfio/vfio_iommu_type1.c b/drivers/vfio/vfio_iommu_type1.c
@@ -555,7 +555,7 @@ static int vfio_iommu_type1_pin_pages(void *iommu_data,
 			continue;
 		}
 
-		remote_vaddr = dma->vaddr + iova - dma->iova;
+		remote_vaddr = dma->vaddr + (iova - dma->iova);
 		ret = vfio_pin_page_external(dma, remote_vaddr, &phys_pfn[i],
 					     do_accounting);
 		if (ret)

Original file line number	Diff line number	Diff line change
`@@ -555,7 +555,7 @@ static int vfio_iommu_type1_pin_pages(void *iommu_data,`
`555`	`555`	`continue;`
`556`	`556`	`}`
`557`	`557`
`558`		`- remote_vaddr = dma->vaddr + iova - dma->iova;`
	`558`	`+ remote_vaddr = dma->vaddr + (iova - dma->iova);`
`559`	`559`	`ret = vfio_pin_page_external(dma, remote_vaddr, &phys_pfn[i],`
`560`	`560`	`do_accounting);`
`561`	`561`	`if (ret)`