Skip to content

Commit 0ef8609

Browse files
mrutland-armwilldeacon
authored andcommitted
ftrace: rename ftrace_instruction_pointer_set() -> ftrace_regs_set_instruction_pointer()
In subsequent patches we'll add a sew of ftrace_regs_{get,set}_*() helpers. In preparation, this patch renames ftrace_instruction_pointer_set() to ftrace_regs_set_instruction_pointer(). There should be no functional change as a result of this patch. Signed-off-by: Mark Rutland <[email protected]> Cc: Florent Revest <[email protected]> Cc: Masami Hiramatsu <[email protected]> Cc: Steven Rostedt <[email protected]> Reviewed-by: Masami Hiramatsu (Google) <[email protected]> Reviewed-by: Steven Rostedt (Google) <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Will Deacon <[email protected]>
1 parent 9705bc7 commit 0ef8609

File tree

5 files changed

+12
-11
lines changed

5 files changed

+12
-11
lines changed

arch/powerpc/include/asm/ftrace.h

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,9 @@ static __always_inline struct pt_regs *arch_ftrace_get_regs(struct ftrace_regs *
3737
return fregs->regs.msr ? &fregs->regs : NULL;
3838
}
3939

40-
static __always_inline void ftrace_instruction_pointer_set(struct ftrace_regs *fregs,
41-
unsigned long ip)
40+
static __always_inline void
41+
ftrace_regs_set_instruction_pointer(struct ftrace_regs *fregs,
42+
unsigned long ip)
4243
{
4344
regs_set_return_ip(&fregs->regs, ip);
4445
}

arch/s390/include/asm/ftrace.h

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,8 +54,9 @@ static __always_inline struct pt_regs *arch_ftrace_get_regs(struct ftrace_regs *
5454
return NULL;
5555
}
5656

57-
static __always_inline void ftrace_instruction_pointer_set(struct ftrace_regs *fregs,
58-
unsigned long ip)
57+
static __always_inline void
58+
ftrace_regs_set_instruction_pointer(struct ftrace_regs *fregs,
59+
unsigned long ip)
5960
{
6061
fregs->regs.psw.addr = ip;
6162
}

arch/x86/include/asm/ftrace.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ arch_ftrace_get_regs(struct ftrace_regs *fregs)
4848
return &fregs->regs;
4949
}
5050

51-
#define ftrace_instruction_pointer_set(fregs, _ip) \
51+
#define ftrace_regs_set_instruction_pointer(fregs, _ip) \
5252
do { (fregs)->regs.ip = (_ip); } while (0)
5353

5454
struct ftrace_ops;

include/linux/ftrace.h

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -111,12 +111,11 @@ struct ftrace_regs {
111111
#define arch_ftrace_get_regs(fregs) (&(fregs)->regs)
112112

113113
/*
114-
* ftrace_instruction_pointer_set() is to be defined by the architecture
115-
* if to allow setting of the instruction pointer from the ftrace_regs
116-
* when HAVE_DYNAMIC_FTRACE_WITH_ARGS is set and it supports
117-
* live kernel patching.
114+
* ftrace_regs_set_instruction_pointer() is to be defined by the architecture
115+
* if to allow setting of the instruction pointer from the ftrace_regs when
116+
* HAVE_DYNAMIC_FTRACE_WITH_ARGS is set and it supports live kernel patching.
118117
*/
119-
#define ftrace_instruction_pointer_set(fregs, ip) do { } while (0)
118+
#define ftrace_regs_set_instruction_pointer(fregs, ip) do { } while (0)
120119
#endif /* CONFIG_HAVE_DYNAMIC_FTRACE_WITH_ARGS */
121120

122121
static __always_inline struct pt_regs *ftrace_get_regs(struct ftrace_regs *fregs)

kernel/livepatch/patch.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@ static void notrace klp_ftrace_handler(unsigned long ip,
118118
if (func->nop)
119119
goto unlock;
120120

121-
ftrace_instruction_pointer_set(fregs, (unsigned long)func->new_func);
121+
ftrace_regs_set_instruction_pointer(fregs, (unsigned long)func->new_func);
122122

123123
unlock:
124124
ftrace_test_recursion_unlock(bit);

0 commit comments

Comments
 (0)