Skip to content

Commit 0f1fe7b

Browse files
committed
Daniel Borkmann says: ==================== pull-request: bpf 2021-12-31 We've added 2 non-merge commits during the last 14 day(s) which contain a total of 2 files changed, 3 insertions(+), 3 deletions(-). The main changes are: 1) Revert of an earlier attempt to fix xsk's poll() behavior where it turned out that the fix for a rare problem made it much worse in general, from Magnus Karlsson. (Fyi, Magnus mentioned that a proper fix is coming early next year, so the revert is mainly to avoid slipping the behavior into 5.16.) 2) Minor misc spell fix in BPF selftests, from Colin Ian King. * https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf: bpf, selftests: Fix spelling mistake "tained" -> "tainted" Revert "xsk: Do not sleep in poll() when need_wakeup set" ==================== Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Jakub Kicinski <[email protected]>
2 parents 4760aba + 819d115 commit 0f1fe7b

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

net/xdp/xsk.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -677,6 +677,8 @@ static __poll_t xsk_poll(struct file *file, struct socket *sock,
677677
struct xdp_sock *xs = xdp_sk(sk);
678678
struct xsk_buff_pool *pool;
679679

680+
sock_poll_wait(file, sock, wait);
681+
680682
if (unlikely(!xsk_is_bound(xs)))
681683
return mask;
682684

@@ -688,8 +690,6 @@ static __poll_t xsk_poll(struct file *file, struct socket *sock,
688690
else
689691
/* Poll needs to drive Tx also in copy mode */
690692
__xsk_sendmsg(sk);
691-
} else {
692-
sock_poll_wait(file, sock, wait);
693693
}
694694

695695
if (xs->rx && !xskq_prod_is_empty(xs->rx))

tools/testing/selftests/bpf/verifier/value_ptr_arith.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1078,7 +1078,7 @@
10781078
.errstr_unpriv = "R0 pointer -= pointer prohibited",
10791079
},
10801080
{
1081-
"map access: trying to leak tained dst reg",
1081+
"map access: trying to leak tainted dst reg",
10821082
.insns = {
10831083
BPF_MOV64_IMM(BPF_REG_0, 0),
10841084
BPF_ST_MEM(BPF_DW, BPF_REG_10, -8, 0),

0 commit comments

Comments
 (0)