Skip to content

Commit 0f7636e

Browse files
paulmenzelpmladek
authored andcommitted
init/Kconfig: Fix CPU number in LOG_CPU_MAX_BUF_SHIFT description
Currently, LOG_BUF_SHIFT defaults to 17, which is 2 ^ 17 bytes = 128 KB, and LOG_CPU_MAX_BUF_SHIFT defaults to 12, which is 2 ^ 12 bytes = 4 KB. Half of 128 KB is 64 KB, so more than 16 CPUs are required for the value to be used, as then the sum of contributions is greater than 64 KB for the first time. My guess is, that the description was written with the configuration values used in the SUSE in mind. Fixes: 23b2899 ("printk: allow increasing the ring buffer depending on the number of CPUs") Cc: Luis R. Rodriguez <[email protected]> Cc: [email protected] Signed-off-by: Paul Menzel <[email protected]> Reviewed-by: Petr Mladek <[email protected]> Signed-off-by: Petr Mladek <[email protected]> Link: https://lore.kernel.org/r/[email protected]
1 parent 8119c43 commit 0f7636e

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

init/Kconfig

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -719,7 +719,7 @@ config LOG_CPU_MAX_BUF_SHIFT
719719
with more CPUs. Therefore this value is used only when the sum of
720720
contributions is greater than the half of the default kernel ring
721721
buffer as defined by LOG_BUF_SHIFT. The default values are set
722-
so that more than 64 CPUs are needed to trigger the allocation.
722+
so that more than 16 CPUs are needed to trigger the allocation.
723723

724724
Also this option is ignored when "log_buf_len" kernel parameter is
725725
used as it forces an exact (power of two) size of the ring buffer.

0 commit comments

Comments
 (0)