Skip to content

Commit 0f8240b

Browse files
Malcolm Priestleygregkh
authored andcommitted
staging: vt6656: Don't set RCR_MULTICAST or RCR_BROADCAST by default.
mac80211/users control whether multicast is on or off don't enable it by default. Fixes an issue when multicast/broadcast is always on allowing other beacons through in power save. Fixes: db8f37f ("staging: vt6656: mac80211 conversion: main_usb add functions...") Cc: stable <[email protected]> Signed-off-by: Malcolm Priestley <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
1 parent c532cc6 commit 0f8240b

File tree

1 file changed

+2
-6
lines changed

1 file changed

+2
-6
lines changed

drivers/staging/vt6656/main_usb.c

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -809,15 +809,11 @@ static void vnt_configure(struct ieee80211_hw *hw,
809809
{
810810
struct vnt_private *priv = hw->priv;
811811
u8 rx_mode = 0;
812-
int rc;
813812

814813
*total_flags &= FIF_ALLMULTI | FIF_OTHER_BSS | FIF_BCN_PRBRESP_PROMISC;
815814

816-
rc = vnt_control_in(priv, MESSAGE_TYPE_READ, MAC_REG_RCR,
817-
MESSAGE_REQUEST_MACREG, sizeof(u8), &rx_mode);
818-
819-
if (!rc)
820-
rx_mode = RCR_MULTICAST | RCR_BROADCAST;
815+
vnt_control_in(priv, MESSAGE_TYPE_READ, MAC_REG_RCR,
816+
MESSAGE_REQUEST_MACREG, sizeof(u8), &rx_mode);
821817

822818
dev_dbg(&priv->usb->dev, "rx mode in = %x\n", rx_mode);
823819

0 commit comments

Comments
 (0)