Skip to content

Commit 100a149

Browse files
Colin Ian Kinggregkh
authored andcommitted
staging: rtl8723bs: remove redundant assignment to variable ret
The variable ret is being assigned an error return value that is never read, the control passes to a return statement and ret is never referenced. Remove the redundant assignment. Also remove an empty line. Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
1 parent 7f921e9 commit 100a149

File tree

1 file changed

+1
-5
lines changed

1 file changed

+1
-5
lines changed

drivers/staging/rtl8723bs/os_dep/osdep_service.c

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -146,10 +146,8 @@ int rtw_change_ifname(struct adapter *padapter, const char *ifname)
146146
rereg_priv->old_pnetdev = cur_pnetdev;
147147

148148
pnetdev = rtw_init_netdev(padapter);
149-
if (!pnetdev) {
150-
ret = -1;
149+
if (!pnetdev)
151150
goto error;
152-
}
153151

154152
SET_NETDEV_DEV(pnetdev, dvobj_to_dev(adapter_to_dvobj(padapter)));
155153

@@ -170,9 +168,7 @@ int rtw_change_ifname(struct adapter *padapter, const char *ifname)
170168
return 0;
171169

172170
error:
173-
174171
return -1;
175-
176172
}
177173

178174
void rtw_buf_free(u8 **buf, u32 *buf_len)

0 commit comments

Comments
 (0)