Skip to content

Commit 1079452

Browse files
Zenghui YuMarc Zyngier
authored andcommitted
irqchip/gic-v3-its: Reference to its_invall_cmd descriptor when building INVALL
It looks like an obvious mistake to use its_mapc_cmd descriptor when building the INVALL command block. It so far worked by luck because both its_mapc_cmd.col and its_invall_cmd.col sit at the same offset of the ITS command descriptor, but we should not rely on it. Fixes: cc2d321 ("irqchip: GICv3: ITS command queue") Signed-off-by: Zenghui Yu <[email protected]> Signed-off-by: Marc Zyngier <[email protected]> Link: https://lore.kernel.org/r/[email protected]
1 parent 656b42d commit 1079452

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/irqchip/irq-gic-v3-its.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -661,7 +661,7 @@ static struct its_collection *its_build_invall_cmd(struct its_node *its,
661661
struct its_cmd_desc *desc)
662662
{
663663
its_encode_cmd(cmd, GITS_CMD_INVALL);
664-
its_encode_collection(cmd, desc->its_mapc_cmd.col->col_id);
664+
its_encode_collection(cmd, desc->its_invall_cmd.col->col_id);
665665

666666
its_fixup_cmd(cmd);
667667

0 commit comments

Comments
 (0)