Skip to content

Commit 10b8a0c

Browse files
Jinjie Ruannmenon
authored andcommitted
soc: ti: knav_qmss_queue: Use IRQF_NO_AUTOEN flag in request_irq()
As commit cbe16f3 ("genirq: Add IRQF_NO_AUTOEN for request_irq/nmi()") said, reqeust_irq() and then disable_irq() is unsafe. In the small time gap between request_irq() and disable_irq(), interrupts can still come. IRQF_NO_AUTOEN flag can be used by drivers to request_irq(). It prevents the automatic enabling of the requested interrupt in the same safe way. With that the usage can be simplified and corrected. Compile-tested only. Signed-off-by: Jinjie Ruan <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Nishanth Menon <[email protected]>
1 parent 9852d85 commit 10b8a0c

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

drivers/soc/ti/knav_qmss_queue.c

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -119,11 +119,10 @@ static int knav_queue_setup_irq(struct knav_range_info *range,
119119

120120
if (range->flags & RANGE_HAS_IRQ) {
121121
irq = range->irqs[queue].irq;
122-
ret = request_irq(irq, knav_queue_int_handler, 0,
123-
inst->irq_name, inst);
122+
ret = request_irq(irq, knav_queue_int_handler, IRQF_NO_AUTOEN,
123+
inst->irq_name, inst);
124124
if (ret)
125125
return ret;
126-
disable_irq(irq);
127126
if (range->irqs[queue].cpu_mask) {
128127
ret = irq_set_affinity_hint(irq, range->irqs[queue].cpu_mask);
129128
if (ret) {

0 commit comments

Comments
 (0)