Skip to content

Commit 110b6d1

Browse files
geliangtangdavem330
authored andcommitted
mptcp: fix a DSS option writing error
'ptr += 1;' was omitted in the original code. If the DSS is the last option -- which is what we have most of the time -- that's not an issue. But it is if we need to send something else after like a RM_ADDR or an MP_PRIO. Fixes: 1bff1e4 ("mptcp: optimize out option generation") Reviewed-by: Matthieu Baerts <[email protected]> Signed-off-by: Geliang Tang <[email protected]> Signed-off-by: Mat Martineau <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 04fac2c commit 110b6d1

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

net/mptcp/options.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1319,6 +1319,7 @@ void mptcp_write_options(__be32 *ptr, const struct tcp_sock *tp,
13191319
put_unaligned_be32(mpext->data_len << 16 |
13201320
TCPOPT_NOP << 8 | TCPOPT_NOP, ptr);
13211321
}
1322+
ptr += 1;
13221323
}
13231324
} else if (OPTIONS_MPTCP_MPC & opts->suboptions) {
13241325
u8 len, flag = MPTCP_CAP_HMAC_SHA256;

0 commit comments

Comments
 (0)