tee: remove unnecessary NULL check in tee_shm_alloc()

Dan Carpenter · jenswi-linaro · commit 1115899e7aad · 2020-04-20T13:12:01.000+02:00
Smatch complains that "ctx" isn't checked consistently:

    drivers/tee/tee_shm.c:164 tee_shm_alloc()
    warn: variable dereferenced before check 'ctx' (see line 95)

I audited the callers and "ctx" can't be NULL so the check can be
removed.

Signed-off-by: Dan Carpenter &lt;dan.carpenter@oracle.com&gt;
Signed-off-by: Jens Wiklander &lt;jens.wiklander@linaro.org&gt;
diff --git a/drivers/tee/tee_shm.c b/drivers/tee/tee_shm.c
@@ -161,8 +161,7 @@ struct tee_shm *tee_shm_alloc(struct tee_context *ctx, size_t size, u32 flags)
 		}
 	}
 
-	if (ctx)
-		teedev_ctx_get(ctx);
+	teedev_ctx_get(ctx);
 
 	return shm;
 err_rem:

Original file line number	Diff line number	Diff line change
`@@ -161,8 +161,7 @@ struct tee_shm tee_shm_alloc(struct tee_context ctx, size_t size, u32 flags)`
`161`	`161`	`}`
`162`	`162`	`}`
`163`	`163`
`164`		`- if (ctx)`
`165`		`- teedev_ctx_get(ctx);`
	`164`	`+ teedev_ctx_get(ctx);`
`166`	`165`
`167`	`166`	`return shm;`
`168`	`167`	`err_rem:`