Skip to content

Commit 113899c

Browse files
committed
drm/i915: Fix one wrong caching mode enum usage
Commit a4d8624 ("drm/i915/gt: Provide a utility to create a scratch buffer") mistakenly passed in uapi I915_CACHING_CACHED as argument to i915_gem_object_set_cache_coherency(), which actually takes internal enum i915_cache_level. No functional issue since the value matches I915_CACHE_LLC (1 == 1), which is the intended caching mode, but lets clean it up nevertheless. Signed-off-by: Tvrtko Ursulin <[email protected]> Fixes: a4d8624 ("drm/i915/gt: Provide a utility to create a scratch buffer") Cc: Daniele Ceraolo Spurio <[email protected]> Reviewed-by: Tejas Upadhyay <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected] (cherry picked from commit 49c60b2) Signed-off-by: Tvrtko Ursulin <[email protected]>
1 parent 6bf0961 commit 113899c

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/gpu/drm/i915/gt/intel_gtt.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -670,7 +670,7 @@ __vm_create_scratch_for_read(struct i915_address_space *vm, unsigned long size)
670670
if (IS_ERR(obj))
671671
return ERR_CAST(obj);
672672

673-
i915_gem_object_set_cache_coherency(obj, I915_CACHING_CACHED);
673+
i915_gem_object_set_cache_coherency(obj, I915_CACHE_LLC);
674674

675675
vma = i915_vma_instance(obj, vm, NULL);
676676
if (IS_ERR(vma)) {

0 commit comments

Comments
 (0)