Skip to content

Commit 115c215

Browse files
Dan Carpenterjic23
authored andcommitted
iio: imu: st_lsm6dsx: unlock on error in st_lsm6dsx_shub_write_raw()
We need to release a lock if st_lsm6dsx_check_odr() fails, we can't return directly. Fixes: 76551a3 ("iio: imu: st_lsm6dsx: specify slave odr in slv_odr") Signed-off-by: Dan Carpenter <[email protected]> Signed-off-by: Jonathan Cameron <[email protected]>
1 parent 98bcead commit 115c215

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_shub.c

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -544,8 +544,10 @@ st_lsm6dsx_shub_write_raw(struct iio_dev *iio_dev,
544544

545545
ref_sensor = iio_priv(hw->iio_devs[ST_LSM6DSX_ID_ACC]);
546546
odr = st_lsm6dsx_check_odr(ref_sensor, val, &odr_val);
547-
if (odr < 0)
548-
return odr;
547+
if (odr < 0) {
548+
err = odr;
549+
goto release;
550+
}
549551

550552
sensor->ext_info.slv_odr = val;
551553
sensor->odr = odr;
@@ -557,6 +559,7 @@ st_lsm6dsx_shub_write_raw(struct iio_dev *iio_dev,
557559
break;
558560
}
559561

562+
release:
560563
iio_device_release_direct_mode(iio_dev);
561564

562565
return err;

0 commit comments

Comments
 (0)