Skip to content

Commit 1174b93

Browse files
Waiman-LongPeter Zijlstra
authored andcommitted
sched/isolation: Make "isolcpus=nohz" equivalent to "nohz_full"
The "isolcpus=nohz" boot parameter and flag were used to disable tick when running a single task. Nowsdays, this "nohz" flag is seldomly used as it is included as part of the "nohz_full" parameter. Extend this flag to cover other kernel noises disabled by the "nohz_full" parameter to make them equivalent. This also eliminates the need to use both the "isolcpus" and the "nohz_full" parameters to fully isolated a given set of CPUs. Suggested-by: Frederic Weisbecker <[email protected]> Signed-off-by: Waiman Long <[email protected]> Signed-off-by: Peter Zijlstra (Intel) <[email protected]> Acked-by: Frederic Weisbecker <[email protected]> Link: https://lore.kernel.org/r/[email protected]
1 parent ae5c677 commit 1174b93

File tree

2 files changed

+8
-2
lines changed

2 files changed

+8
-2
lines changed

Documentation/admin-guide/kernel-parameters.txt

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2432,7 +2432,9 @@
24322432
specified in the flag list (default: domain):
24332433

24342434
nohz
2435-
Disable the tick when a single task runs.
2435+
Disable the tick when a single task runs as well as
2436+
disabling other kernel noises like having RCU callbacks
2437+
offloaded. This is equivalent to the nohz_full parameter.
24362438

24372439
A residual 1Hz tick is offloaded to workqueues, which you
24382440
need to affine to housekeeping through the global

kernel/sched/isolation.c

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -209,9 +209,13 @@ static int __init housekeeping_isolcpus_setup(char *str)
209209
int len;
210210

211211
while (isalpha(*str)) {
212+
/*
213+
* isolcpus=nohz is equivalent to nohz_full.
214+
*/
212215
if (!strncmp(str, "nohz,", 5)) {
213216
str += 5;
214-
flags |= HK_FLAG_TICK;
217+
flags |= HK_FLAG_TICK | HK_FLAG_WQ | HK_FLAG_TIMER |
218+
HK_FLAG_RCU | HK_FLAG_MISC | HK_FLAG_KTHREAD;
215219
continue;
216220
}
217221

0 commit comments

Comments
 (0)