Skip to content

Commit 11af4c3

Browse files
author
Marc Zyngier
committed
KVM: arm64: PMU: Implement PMUv3p5 long counter support
PMUv3p5 (which is mandatory with ARMv8.5) comes with some extra features: - All counters are 64bit - The overflow point is controlled by the PMCR_EL0.LP bit Add the required checks in the helpers that control counter width and overflow, as well as the sysreg handling for the LP bit. A new kvm_pmu_is_3p5() helper makes it easy to spot the PMUv3p5 specific handling. Signed-off-by: Marc Zyngier <[email protected]> Link: https://lore.kernel.org/r/[email protected]
1 parent d82e0df commit 11af4c3

File tree

3 files changed

+16
-3
lines changed

3 files changed

+16
-3
lines changed

arch/arm64/kvm/pmu-emul.c

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -52,13 +52,15 @@ static u32 kvm_pmu_event_mask(struct kvm *kvm)
5252
*/
5353
static bool kvm_pmu_idx_is_64bit(struct kvm_vcpu *vcpu, u64 select_idx)
5454
{
55-
return (select_idx == ARMV8_PMU_CYCLE_IDX);
55+
return (select_idx == ARMV8_PMU_CYCLE_IDX || kvm_pmu_is_3p5(vcpu));
5656
}
5757

5858
static bool kvm_pmu_idx_has_64bit_overflow(struct kvm_vcpu *vcpu, u64 select_idx)
5959
{
60-
return (select_idx == ARMV8_PMU_CYCLE_IDX &&
61-
__vcpu_sys_reg(vcpu, PMCR_EL0) & ARMV8_PMU_PMCR_LC);
60+
u64 val = __vcpu_sys_reg(vcpu, PMCR_EL0);
61+
62+
return (select_idx < ARMV8_PMU_CYCLE_IDX && (val & ARMV8_PMU_PMCR_LP)) ||
63+
(select_idx == ARMV8_PMU_CYCLE_IDX && (val & ARMV8_PMU_PMCR_LC));
6264
}
6365

6466
static bool kvm_pmu_counter_can_chain(struct kvm_vcpu *vcpu, u64 idx)

arch/arm64/kvm/sys_regs.c

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -654,6 +654,8 @@ static void reset_pmcr(struct kvm_vcpu *vcpu, const struct sys_reg_desc *r)
654654
| (ARMV8_PMU_PMCR_MASK & 0xdecafbad)) & (~ARMV8_PMU_PMCR_E);
655655
if (!kvm_supports_32bit_el0())
656656
val |= ARMV8_PMU_PMCR_LC;
657+
if (!kvm_pmu_is_3p5(vcpu))
658+
val &= ~ARMV8_PMU_PMCR_LP;
657659
__vcpu_sys_reg(vcpu, r->reg) = val;
658660
}
659661

@@ -703,6 +705,8 @@ static bool access_pmcr(struct kvm_vcpu *vcpu, struct sys_reg_params *p,
703705
val |= p->regval & ARMV8_PMU_PMCR_MASK;
704706
if (!kvm_supports_32bit_el0())
705707
val |= ARMV8_PMU_PMCR_LC;
708+
if (!kvm_pmu_is_3p5(vcpu))
709+
val &= ~ARMV8_PMU_PMCR_LP;
706710
__vcpu_sys_reg(vcpu, PMCR_EL0) = val;
707711
kvm_pmu_handle_pmcr(vcpu, val);
708712
kvm_vcpu_pmu_restore_guest(vcpu);

include/kvm/arm_pmu.h

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -89,6 +89,12 @@ void kvm_vcpu_pmu_restore_host(struct kvm_vcpu *vcpu);
8989
vcpu->arch.pmu.events = *kvm_get_pmu_events(); \
9090
} while (0)
9191

92+
/*
93+
* Evaluates as true when emulating PMUv3p5, and false otherwise.
94+
*/
95+
#define kvm_pmu_is_3p5(vcpu) \
96+
(vcpu->kvm->arch.dfr0_pmuver.imp >= ID_AA64DFR0_EL1_PMUVer_V3P5)
97+
9298
u8 kvm_arm_pmu_get_pmuver_limit(void);
9399

94100
#else
@@ -153,6 +159,7 @@ static inline u64 kvm_pmu_get_pmceid(struct kvm_vcpu *vcpu, bool pmceid1)
153159
}
154160

155161
#define kvm_vcpu_has_pmu(vcpu) ({ false; })
162+
#define kvm_pmu_is_3p5(vcpu) ({ false; })
156163
static inline void kvm_pmu_update_vcpu_events(struct kvm_vcpu *vcpu) {}
157164
static inline void kvm_vcpu_pmu_restore_guest(struct kvm_vcpu *vcpu) {}
158165
static inline void kvm_vcpu_pmu_restore_host(struct kvm_vcpu *vcpu) {}

0 commit comments

Comments
 (0)