Skip to content

Commit 11c79df

Browse files
Dr. David Alan Gilbertmartinkpetersen
authored andcommitted
scsi: isci: Make most module parameters static
Most of the module parameters are only used locally in the same C file; so static them. Signed-off-by: Dr. David Alan Gilbert <[email protected]> Link: https://lore.kernel.org/r/[email protected] Reviewed-by: Damien Le Moal <[email protected]> Signed-off-by: Martin K. Petersen <[email protected]>
1 parent b79e4a2 commit 11c79df

File tree

2 files changed

+7
-14
lines changed

2 files changed

+7
-14
lines changed

drivers/scsi/isci/init.c

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -91,31 +91,31 @@ MODULE_DEVICE_TABLE(pci, isci_id_table);
9191

9292
/* linux isci specific settings */
9393

94-
unsigned char no_outbound_task_to = 2;
94+
static unsigned char no_outbound_task_to = 2;
9595
module_param(no_outbound_task_to, byte, 0);
9696
MODULE_PARM_DESC(no_outbound_task_to, "No Outbound Task Timeout (1us incr)");
9797

98-
u16 ssp_max_occ_to = 20;
98+
static u16 ssp_max_occ_to = 20;
9999
module_param(ssp_max_occ_to, ushort, 0);
100100
MODULE_PARM_DESC(ssp_max_occ_to, "SSP Max occupancy timeout (100us incr)");
101101

102-
u16 stp_max_occ_to = 5;
102+
static u16 stp_max_occ_to = 5;
103103
module_param(stp_max_occ_to, ushort, 0);
104104
MODULE_PARM_DESC(stp_max_occ_to, "STP Max occupancy timeout (100us incr)");
105105

106-
u16 ssp_inactive_to = 5;
106+
static u16 ssp_inactive_to = 5;
107107
module_param(ssp_inactive_to, ushort, 0);
108108
MODULE_PARM_DESC(ssp_inactive_to, "SSP inactivity timeout (100us incr)");
109109

110-
u16 stp_inactive_to = 5;
110+
static u16 stp_inactive_to = 5;
111111
module_param(stp_inactive_to, ushort, 0);
112112
MODULE_PARM_DESC(stp_inactive_to, "STP inactivity timeout (100us incr)");
113113

114-
unsigned char phy_gen = SCIC_SDS_PARM_GEN2_SPEED;
114+
static unsigned char phy_gen = SCIC_SDS_PARM_GEN2_SPEED;
115115
module_param(phy_gen, byte, 0);
116116
MODULE_PARM_DESC(phy_gen, "PHY generation (1: 1.5Gbps 2: 3.0Gbps 3: 6.0Gbps)");
117117

118-
unsigned char max_concurr_spinup;
118+
static unsigned char max_concurr_spinup;
119119
module_param(max_concurr_spinup, byte, 0);
120120
MODULE_PARM_DESC(max_concurr_spinup, "Max concurrent device spinup");
121121

drivers/scsi/isci/isci.h

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -473,13 +473,6 @@ static inline void sci_swab32_cpy(void *_dest, void *_src, ssize_t word_cnt)
473473
dest[word_cnt] = swab32(src[word_cnt]);
474474
}
475475

476-
extern unsigned char no_outbound_task_to;
477-
extern u16 ssp_max_occ_to;
478-
extern u16 stp_max_occ_to;
479-
extern u16 ssp_inactive_to;
480-
extern u16 stp_inactive_to;
481-
extern unsigned char phy_gen;
482-
extern unsigned char max_concurr_spinup;
483476
extern uint cable_selection_override;
484477

485478
irqreturn_t isci_msix_isr(int vec, void *data);

0 commit comments

Comments
 (0)