Skip to content

Commit 1228241

Browse files
ideakvgovind2
authored andcommitted
drm/xe: Handle polling only for system s/r in xe_display_pm_suspend/resume()
This is a preparation for the follow-up patch where polling will be handled properly for all cases during runtime suspend/resume. v2: rebased Reviewed-by: Arun R Murthy <[email protected]> Signed-off-by: Imre Deak <[email protected]> Signed-off-by: Vinod Govindapillai <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
1 parent a64e7e5 commit 1228241

File tree

1 file changed

+6
-12
lines changed

1 file changed

+6
-12
lines changed

drivers/gpu/drm/xe/display/xe_display.c

Lines changed: 6 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -321,14 +321,11 @@ void xe_display_pm_suspend(struct xe_device *xe, bool runtime)
321321
*/
322322
intel_power_domains_disable(xe);
323323
intel_fbdev_set_suspend(&xe->drm, FBINFO_STATE_SUSPENDED, true);
324-
if (has_display(xe)) {
324+
if (!runtime && has_display(xe)) {
325325
drm_kms_helper_poll_disable(&xe->drm);
326-
if (!runtime)
327-
intel_display_driver_disable_user_access(xe);
328-
}
329-
330-
if (!runtime)
326+
intel_display_driver_disable_user_access(xe);
331327
intel_display_driver_suspend(xe);
328+
}
332329

333330
xe_display_flush_cleanup_work(xe);
334331

@@ -387,15 +384,12 @@ void xe_display_pm_resume(struct xe_device *xe, bool runtime)
387384

388385
/* MST sideband requires HPD interrupts enabled */
389386
intel_dp_mst_resume(xe);
390-
if (!runtime)
387+
if (!runtime && has_display(xe)) {
391388
intel_display_driver_resume(xe);
392-
393-
if (has_display(xe)) {
394389
drm_kms_helper_poll_enable(&xe->drm);
395-
if (!runtime)
396-
intel_display_driver_enable_user_access(xe);
390+
intel_display_driver_enable_user_access(xe);
391+
intel_hpd_poll_disable(xe);
397392
}
398-
intel_hpd_poll_disable(xe);
399393

400394
intel_opregion_resume(display);
401395

0 commit comments

Comments
 (0)