Skip to content

Commit 12b90b4

Browse files
ISCAS-Vulabbebarino
authored andcommitted
clk: clk-atlas6: fix return value check in atlas6_clk_init()
In case of error, the function clk_register() returns ERR_PTR() and never returns NULL. The NULL test in the return value check should be replaced with IS_ERR(). Signed-off-by: Xu Wang <[email protected]> Link: https://lore.kernel.org/r/[email protected] Acked-by: Barry Song <[email protected]> Fixes: 7bf21bc ("clk: sirf: re-arch to make the codes support both prima2 and atlas6") Signed-off-by: Stephen Boyd <[email protected]>
1 parent b3a9e3b commit 12b90b4

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/clk/sirf/clk-atlas6.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,7 @@ static void __init atlas6_clk_init(struct device_node *np)
135135

136136
for (i = pll1; i < maxclk; i++) {
137137
atlas6_clks[i] = clk_register(NULL, atlas6_clk_hw_array[i]);
138-
BUG_ON(!atlas6_clks[i]);
138+
BUG_ON(IS_ERR(atlas6_clks[i]));
139139
}
140140
clk_register_clkdev(atlas6_clks[cpu], NULL, "cpu");
141141
clk_register_clkdev(atlas6_clks[io], NULL, "io");

0 commit comments

Comments
 (0)