Skip to content

Commit 1325820

Browse files
prabhakarladgeertu
authored andcommitted
pinctrl: renesas: rzg2l: Move pinconf_to_config_argument() call outside of switch cases
Refactor the `rzg2l_pinctrl_pinconf_set()` function by moving the call to `arg = pinconf_to_config_argument(_configs[i])` to the beginning of the loop. Previously, this call was redundantly made in most cases within the switch statement. Signed-off-by: Lad Prabhakar <[email protected]> Reviewed-by: Geert Uytterhoeven <[email protected]> Link: https://lore.kernel.org/[email protected] Signed-off-by: Geert Uytterhoeven <[email protected]>
1 parent befcded commit 1325820

File tree

1 file changed

+3
-11
lines changed

1 file changed

+3
-11
lines changed

drivers/pinctrl/renesas/pinctrl-rzg2l.c

Lines changed: 3 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1385,9 +1385,9 @@ static int rzg2l_pinctrl_pinconf_set(struct pinctrl_dev *pctldev,
13851385

13861386
for (i = 0; i < num_configs; i++) {
13871387
param = pinconf_to_config_param(_configs[i]);
1388+
arg = pinconf_to_config_argument(_configs[i]);
13881389
switch (param) {
13891390
case PIN_CONFIG_INPUT_ENABLE:
1390-
arg = pinconf_to_config_argument(_configs[i]);
13911391

13921392
if (!(cfg & PIN_CFG_IEN))
13931393
return -EINVAL;
@@ -1396,7 +1396,6 @@ static int rzg2l_pinctrl_pinconf_set(struct pinctrl_dev *pctldev,
13961396
break;
13971397

13981398
case PIN_CONFIG_OUTPUT_ENABLE:
1399-
arg = pinconf_to_config_argument(_configs[i]);
14001399
if (!(cfg & PIN_CFG_OEN))
14011400
return -EINVAL;
14021401
if (!pctrl->data->oen_write)
@@ -1407,12 +1406,10 @@ static int rzg2l_pinctrl_pinconf_set(struct pinctrl_dev *pctldev,
14071406
break;
14081407

14091408
case PIN_CONFIG_POWER_SOURCE:
1410-
settings.power_source = pinconf_to_config_argument(_configs[i]);
1409+
settings.power_source = arg;
14111410
break;
14121411

14131412
case PIN_CONFIG_SLEW_RATE:
1414-
arg = pinconf_to_config_argument(_configs[i]);
1415-
14161413
if (!(cfg & PIN_CFG_SR) || arg > 1)
14171414
return -EINVAL;
14181415

@@ -1433,8 +1430,6 @@ static int rzg2l_pinctrl_pinconf_set(struct pinctrl_dev *pctldev,
14331430
break;
14341431

14351432
case PIN_CONFIG_DRIVE_STRENGTH:
1436-
arg = pinconf_to_config_argument(_configs[i]);
1437-
14381433
if (!(cfg & PIN_CFG_IOLH_A) || hwcfg->drive_strength_ua)
14391434
return -EINVAL;
14401435

@@ -1454,12 +1449,10 @@ static int rzg2l_pinctrl_pinconf_set(struct pinctrl_dev *pctldev,
14541449
!hwcfg->drive_strength_ua)
14551450
return -EINVAL;
14561451

1457-
settings.drive_strength_ua = pinconf_to_config_argument(_configs[i]);
1452+
settings.drive_strength_ua = arg;
14581453
break;
14591454

14601455
case PIN_CONFIG_OUTPUT_IMPEDANCE_OHMS:
1461-
arg = pinconf_to_config_argument(_configs[i]);
1462-
14631456
if (!(cfg & PIN_CFG_IOLH_B) || !hwcfg->iolh_groupb_oi[0])
14641457
return -EINVAL;
14651458

@@ -1477,7 +1470,6 @@ static int rzg2l_pinctrl_pinconf_set(struct pinctrl_dev *pctldev,
14771470
if (!(cfg & PIN_CFG_IOLH_RZV2H))
14781471
return -EINVAL;
14791472

1480-
arg = pinconf_to_config_argument(_configs[i]);
14811473
if (arg > 3)
14821474
return -EINVAL;
14831475
rzg2l_rmw_pin_config(pctrl, IOLH(off), bit, IOLH_MASK, arg);

0 commit comments

Comments
 (0)