Skip to content

Commit 1329e40

Browse files
committed
selftests/net: remove ARRAY_SIZE define from individual tests
ARRAY_SIZE is defined in several selftests. Remove definitions from individual test files and include header file for the define instead. ARRAY_SIZE define is added in a separate patch to prepare for this change. Remove ARRAY_SIZE from net tests and pickup the one defined in kselftest.h. Signed-off-by: Shuah Khan <[email protected]>
1 parent 5a69d33 commit 1329e40

File tree

6 files changed

+8
-11
lines changed

6 files changed

+8
-11
lines changed

tools/testing/selftests/net/gro.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,10 +57,11 @@
5757
#include <string.h>
5858
#include <unistd.h>
5959

60+
#include "../kselftest.h"
61+
6062
#define DPORT 8000
6163
#define SPORT 1500
6264
#define PAYLOAD_LEN 100
63-
#define ARRAY_SIZE(arr) (sizeof(arr) / sizeof((arr)[0]))
6465
#define NUM_PACKETS 4
6566
#define START_SEQ 100
6667
#define START_ACK 100

tools/testing/selftests/net/ipsec.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,6 @@
4141

4242
#define pr_err(fmt, ...) printk(fmt ": %m", ##__VA_ARGS__)
4343

44-
#define ARRAY_SIZE(arr) (sizeof(arr) / sizeof((arr)[0]))
4544
#define BUILD_BUG_ON(condition) ((void)sizeof(char[1 - 2*!!(condition)]))
4645

4746
#define IPV4_STR_SZ 16 /* xxx.xxx.xxx.xxx is longest + \0 */

tools/testing/selftests/net/reuseport_bpf.c

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,7 @@
2424
#include <sys/resource.h>
2525
#include <unistd.h>
2626

27-
#ifndef ARRAY_SIZE
28-
#define ARRAY_SIZE(arr) (sizeof(arr) / sizeof((arr)[0]))
29-
#endif
27+
#include "../kselftest.h"
3028

3129
struct test_params {
3230
int recv_family;

tools/testing/selftests/net/rxtimestamp.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
#include <linux/net_tstamp.h>
1919
#include <linux/errqueue.h>
2020

21-
#define ARRAY_SIZE(arr) (sizeof(arr) / sizeof((arr)[0]))
21+
#include "../kselftest.h"
2222

2323
struct options {
2424
int so_timestamp;

tools/testing/selftests/net/socket.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77
#include <sys/socket.h>
88
#include <netinet/in.h>
99

10+
#include "../kselftest.h"
11+
1012
struct socket_testcase {
1113
int domain;
1214
int type;
@@ -31,7 +33,6 @@ static struct socket_testcase tests[] = {
3133
{ AF_INET, SOCK_STREAM, IPPROTO_UDP, -EPROTONOSUPPORT, 1 },
3234
};
3335

34-
#define ARRAY_SIZE(arr) (sizeof(arr) / sizeof((arr)[0]))
3536
#define ERR_STRING_SZ 64
3637

3738
static int run_tests(void)

tools/testing/selftests/net/tcp_fastopen_backup_key.c

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,8 @@
2626
#include <fcntl.h>
2727
#include <time.h>
2828

29+
#include "../kselftest.h"
30+
2931
#ifndef TCP_FASTOPEN_KEY
3032
#define TCP_FASTOPEN_KEY 33
3133
#endif
@@ -34,10 +36,6 @@
3436
#define PROC_FASTOPEN_KEY "/proc/sys/net/ipv4/tcp_fastopen_key"
3537
#define KEY_LENGTH 16
3638

37-
#ifndef ARRAY_SIZE
38-
#define ARRAY_SIZE(arr) (sizeof(arr) / sizeof((arr)[0]))
39-
#endif
40-
4139
static bool do_ipv6;
4240
static bool do_sockopt;
4341
static bool do_rotate;

0 commit comments

Comments
 (0)