Skip to content

Commit 132c1e7

Browse files
hfreudeVasily Gorbik
authored andcommitted
s390/ap: function rework based on compiler warning
Slight rework of function __ap_revise_reserved() because of unused variable warning when build with W=1. This patch introduces an additional debug feature warning message when device_reprobe() returns with failure. However, the return value of __ap_revise_reserved() is still hard coded to 0 as this is a callback function to be used together with bus_for_each_dev() and thus the return value indicates to go on with the bus_for_each_dev() loop and not apport on a failure of something within this function. Signed-off-by: Harald Freudenberger <[email protected]> Signed-off-by: Vasily Gorbik <[email protected]>
1 parent ad9a145 commit 132c1e7

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

drivers/s390/crypto/ap_bus.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -793,6 +793,9 @@ static int __ap_revise_reserved(struct device *dev, void *dummy)
793793
AP_DBF_DBG("%s reprobing queue=%02x.%04x\n",
794794
__func__, card, queue);
795795
rc = device_reprobe(dev);
796+
if (rc)
797+
AP_DBF_WARN("%s reprobing queue=%02x.%04x failed\n",
798+
__func__, card, queue);
796799
}
797800
}
798801

0 commit comments

Comments
 (0)