Skip to content

Commit 134043c

Browse files
JasonYanHwrafaeljw
authored andcommitted
ACPI: PAD: Eliminate usage of uninitialized_var() macro
This is an effort to eliminate the uninitialized_var() macro[1]. The use of this macro is the wrong solution because it forces off ANY analysis by the compiler for a given variable. It even masks "unused variable" warnings. Quoted from Linus[2]: "It's a horrible thing to use, in that it adds extra cruft to the source code, and then shuts up a compiler warning (even the _reliable_ warnings from gcc)." The gcc option "-Wmaybe-uninitialized" has been disabled and this change will not produce any warnnings even with "make W=1". Link: KSPP#81 # [1] Link: https://lore.kernel.org/lkml/CA+55aFz2500WfbKXAx8s67wrm9=yVJu65TpLgN_ybYNv0VEOKA@mail.gmail.com/ # [2] Signed-off-by: Jason Yan <[email protected]> Signed-off-by: Rafael J. Wysocki <[email protected]>
1 parent 4877846 commit 134043c

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/acpi/acpi_pad.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ static void round_robin_cpu(unsigned int tsk_index)
8888
cpumask_var_t tmp;
8989
int cpu;
9090
unsigned long min_weight = -1;
91-
unsigned long uninitialized_var(preferred_cpu);
91+
unsigned long preferred_cpu;
9292

9393
if (!alloc_cpumask_var(&tmp, GFP_KERNEL))
9494
return;

0 commit comments

Comments
 (0)