Skip to content

Commit 134c37f

Browse files
arndbvinodkoul
authored andcommitted
dmaengine: pxa/mmp: stop referencing config->slave_id
The last driver referencing the slave_id on Marvell PXA and MMP platforms was the SPI driver, but this stopped doing so a long time ago, so the TODO from the earlier patch can no be removed. Fixes: b729bf3 ("spi/pxa2xx: Don't use slave_id of dma_slave_config") Fixes: 13b3006 ("dma: mmp_pdma: add filter function") Signed-off-by: Arnd Bergmann <[email protected]> Acked-by: Mark Brown <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Vinod Koul <[email protected]>
1 parent 37228af commit 134c37f

File tree

2 files changed

+0
-13
lines changed

2 files changed

+0
-13
lines changed

drivers/dma/mmp_pdma.c

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -727,12 +727,6 @@ static int mmp_pdma_config_write(struct dma_chan *dchan,
727727

728728
chan->dir = direction;
729729
chan->dev_addr = addr;
730-
/* FIXME: drivers should be ported over to use the filter
731-
* function. Once that's done, the following two lines can
732-
* be removed.
733-
*/
734-
if (cfg->slave_id)
735-
chan->drcmr = cfg->slave_id;
736730

737731
return 0;
738732
}

drivers/dma/pxa_dma.c

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -909,13 +909,6 @@ static void pxad_get_config(struct pxad_chan *chan,
909909
*dcmd |= PXA_DCMD_BURST16;
910910
else if (maxburst == 32)
911911
*dcmd |= PXA_DCMD_BURST32;
912-
913-
/* FIXME: drivers should be ported over to use the filter
914-
* function. Once that's done, the following two lines can
915-
* be removed.
916-
*/
917-
if (chan->cfg.slave_id)
918-
chan->drcmr = chan->cfg.slave_id;
919912
}
920913

921914
static struct dma_async_tx_descriptor *

0 commit comments

Comments
 (0)