Skip to content

Commit 134f49d

Browse files
tititiou36gregkh
authored andcommitted
serial: 8250_tegra: Fix an error handling path in tegra_uart_probe()
If an error occurs after reset_control_deassert(), it must be re-asserted, as already done in the .remove() function. Fixes: c6825c6 ("serial: 8250_tegra: Create Tegra specific 8250 driver") Cc: stable <[email protected]> Signed-off-by: Christophe JAILLET <[email protected]> Link: https://lore.kernel.org/r/f8130f35339cc80edc6b9aac4bb2a60b60a226bf.1684063511.git.christophe.jaillet@wanadoo.fr Signed-off-by: Greg Kroah-Hartman <[email protected]>
1 parent 44c026a commit 134f49d

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

drivers/tty/serial/8250/8250_tegra.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,13 +113,15 @@ static int tegra_uart_probe(struct platform_device *pdev)
113113

114114
ret = serial8250_register_8250_port(&port8250);
115115
if (ret < 0)
116-
goto err_clkdisable;
116+
goto err_ctrl_assert;
117117

118118
platform_set_drvdata(pdev, uart);
119119
uart->line = ret;
120120

121121
return 0;
122122

123+
err_ctrl_assert:
124+
reset_control_assert(uart->rst);
123125
err_clkdisable:
124126
clk_disable_unprepare(uart->clk);
125127

0 commit comments

Comments
 (0)