Skip to content

Commit 1372e73

Browse files
author
Jiri Kosina
committed
Merge branch 'for-6.7/uclogic' into for-linus
- fixes for crashes detected by CONFIG_KUNIT_ALL_TESTS in hid-uclogic driver (Jinjie Ruan)
2 parents e12f065 + d45f72b commit 1372e73

File tree

2 files changed

+22
-1
lines changed

2 files changed

+22
-1
lines changed

drivers/hid/hid-uclogic-core-test.c

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,11 @@ static struct uclogic_raw_event_hook_test test_events[] = {
5656
},
5757
};
5858

59+
static void fake_work(struct work_struct *work)
60+
{
61+
62+
}
63+
5964
static void hid_test_uclogic_exec_event_hook_test(struct kunit *test)
6065
{
6166
struct uclogic_params p = {0, };
@@ -77,6 +82,8 @@ static void hid_test_uclogic_exec_event_hook_test(struct kunit *test)
7782
KUNIT_ASSERT_NOT_ERR_OR_NULL(test, filter->event);
7883
memcpy(filter->event, &hook_events[n].event[0], filter->size);
7984

85+
INIT_WORK(&filter->work, fake_work);
86+
8087
list_add_tail(&filter->list, &p.event_hooks->list);
8188
}
8289

drivers/hid/hid-uclogic-params-test.c

Lines changed: 15 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -174,12 +174,26 @@ static void hid_test_uclogic_parse_ugee_v2_desc(struct kunit *test)
174174
KUNIT_EXPECT_EQ(test, params->frame_type, frame_type);
175175
}
176176

177+
struct fake_device {
178+
unsigned long quirks;
179+
};
180+
177181
static void hid_test_uclogic_params_cleanup_event_hooks(struct kunit *test)
178182
{
179183
int res, n;
184+
struct hid_device *hdev;
185+
struct fake_device *fake_dev;
180186
struct uclogic_params p = {0, };
181187

182-
res = uclogic_params_ugee_v2_init_event_hooks(NULL, &p);
188+
hdev = kunit_kzalloc(test, sizeof(struct hid_device), GFP_KERNEL);
189+
KUNIT_ASSERT_NOT_ERR_OR_NULL(test, hdev);
190+
191+
fake_dev = kunit_kzalloc(test, sizeof(struct fake_device), GFP_KERNEL);
192+
KUNIT_ASSERT_NOT_ERR_OR_NULL(test, fake_dev);
193+
194+
hid_set_drvdata(hdev, fake_dev);
195+
196+
res = uclogic_params_ugee_v2_init_event_hooks(hdev, &p);
183197
KUNIT_ASSERT_EQ(test, res, 0);
184198

185199
/* Check that the function can be called repeatedly */

0 commit comments

Comments
 (0)