Skip to content

Commit 1382d8b

Browse files
ColinIanKingbroonie
authored andcommitted
ASoC: qcom: Fix uninitialized pointer dmactl
In the case where __lpass_get_dmactl_handle is called and the driver id dai_id is invalid the pointer dmactl is not being assigned a value, and dmactl contains a garbage value since it has not been initialized and so the null check may not work. Fix this to initialize dmactl to NULL. One could argue that modern compilers will set this to zero, but it is useful to keep this initialized as per the same way in functions __lpass_platform_codec_intf_init and lpass_cdc_dma_daiops_hw_params. Cleans up clang scan build warning: sound/soc/qcom/lpass-cdc-dma.c:275:7: warning: Branch condition evaluates to a garbage value [core.uninitialized.Branch] Fixes: b81af58 ("ASoC: qcom: Add lpass CPU driver for codec dma control") Signed-off-by: Colin Ian King <[email protected]> Link: https://msgid.link/r/[email protected] Signed-off-by: Mark Brown <[email protected]>
1 parent e33625c commit 1382d8b

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

sound/soc/qcom/lpass-cdc-dma.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -259,7 +259,7 @@ static int lpass_cdc_dma_daiops_trigger(struct snd_pcm_substream *substream,
259259
int cmd, struct snd_soc_dai *dai)
260260
{
261261
struct snd_soc_pcm_runtime *soc_runtime = snd_soc_substream_to_rtd(substream);
262-
struct lpaif_dmactl *dmactl;
262+
struct lpaif_dmactl *dmactl = NULL;
263263
int ret = 0, id;
264264

265265
switch (cmd) {

0 commit comments

Comments
 (0)