Skip to content

Commit 13fbe78

Browse files
Jiri Slabysuryasaimadhu
authored andcommitted
x86/asm: Replace WEAK uses by SYM_INNER_LABEL_ALIGN
Use the new SYM_INNER_LABEL_ALIGN for WEAK entries in the middle of x86 assembly functions. And make sure WEAK is not defined for x86 anymore as these were the last users. Signed-off-by: Jiri Slaby <[email protected]> Signed-off-by: Borislav Petkov <[email protected]> Cc: Andrey Ryabinin <[email protected]> Cc: Boris Ostrovsky <[email protected]> Cc: Herbert Xu <[email protected]> Cc: "H. Peter Anvin" <[email protected]> Cc: Ingo Molnar <[email protected]> Cc: Josh Poimboeuf <[email protected]> Cc: [email protected] Cc: Mark Rutland <[email protected]> Cc: Peter Zijlstra <[email protected]> Cc: "Rafael J. Wysocki" <[email protected]> Cc: "Steven Rostedt (VMware)" <[email protected]> Cc: Thomas Gleixner <[email protected]> Cc: x86-ml <[email protected]> Link: https://lkml.kernel.org/r/[email protected]
1 parent 6d685e5 commit 13fbe78

File tree

4 files changed

+4
-4
lines changed

4 files changed

+4
-4
lines changed

arch/x86/kernel/ftrace_32.S

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ ftrace_graph_call:
8585
#endif
8686

8787
/* This is weak to keep gas from relaxing the jumps */
88-
WEAK(ftrace_stub)
88+
SYM_INNER_LABEL_ALIGN(ftrace_stub, SYM_L_WEAK)
8989
ret
9090
SYM_CODE_END(ftrace_caller)
9191

arch/x86/kernel/ftrace_64.S

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -168,7 +168,7 @@ SYM_INNER_LABEL(ftrace_graph_call, SYM_L_GLOBAL)
168168
* This is weak to keep gas from relaxing the jumps.
169169
* It is also used to copy the retq for trampolines.
170170
*/
171-
WEAK(ftrace_stub)
171+
SYM_INNER_LABEL_ALIGN(ftrace_stub, SYM_L_WEAK)
172172
retq
173173
SYM_FUNC_END(ftrace_caller)
174174

arch/x86/kernel/head_32.S

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,7 @@ SYM_CODE_START(startup_32)
156156
jmp *%eax
157157

158158
.Lbad_subarch:
159-
WEAK(xen_entry)
159+
SYM_INNER_LABEL_ALIGN(xen_entry, SYM_L_WEAK)
160160
/* Unknown implementation; there's really
161161
nothing we can do at this point. */
162162
ud2a

include/linux/linkage.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -121,13 +121,13 @@
121121
#endif /* CONFIG_X86 */
122122
#endif /* LINKER_SCRIPT */
123123

124+
#ifndef CONFIG_X86
124125
#ifndef WEAK
125126
/* deprecated, use SYM_FUNC_START_WEAK* */
126127
#define WEAK(name) \
127128
SYM_FUNC_START_WEAK(name)
128129
#endif
129130

130-
#ifndef CONFIG_X86
131131
#ifndef END
132132
/* deprecated, use SYM_FUNC_END, SYM_DATA_END, or SYM_END */
133133
#define END(name) \

0 commit comments

Comments
 (0)