Skip to content

Commit 14110af

Browse files
seehearfeelLorenzo Pieralisi
authored andcommitted
PCI: loongson: Use DECLARE_PCI_FIXUP_EARLY for bridge_class_quirk()
According to the datasheet of Loongson LS7A bridge chip, the old version of Loongson LS7A PCIE port has a wrong value about PCI class which is 0x060000, the correct value should be 0x060400, this bug can be fixed by "dev->class = PCI_CLASS_BRIDGE_PCI << 8;" at the software level and it was fixed in hardware in the latest LS7A versions. In order to maintain downward compatibility, use DECLARE_PCI_FIXUP_EARLY instead of DECLARE_PCI_FIXUP_HEADER for bridge_class_quirk() to fix it as early as possible. Otherwise, in the function pci_setup_device(), the related code about "dev->class" such as "class = dev->class >> 8;" and "dev->transparent = ((dev->class & 0xff) == 1);" maybe get wrong value without EARLY fixup. Link: https://lore.kernel.org/r/[email protected] Fixes: 1f58cca ("PCI: Add Loongson PCI Controller support") Signed-off-by: Tiezhu Yang <[email protected]> Signed-off-by: Lorenzo Pieralisi <[email protected]>
1 parent b3a9e3b commit 14110af

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

drivers/pci/controller/pci-loongson.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -37,11 +37,11 @@ static void bridge_class_quirk(struct pci_dev *dev)
3737
{
3838
dev->class = PCI_CLASS_BRIDGE_PCI << 8;
3939
}
40-
DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_LOONGSON,
40+
DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_LOONGSON,
4141
DEV_PCIE_PORT_0, bridge_class_quirk);
42-
DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_LOONGSON,
42+
DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_LOONGSON,
4343
DEV_PCIE_PORT_1, bridge_class_quirk);
44-
DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_LOONGSON,
44+
DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_LOONGSON,
4545
DEV_PCIE_PORT_2, bridge_class_quirk);
4646

4747
static void system_bus_quirk(struct pci_dev *pdev)

0 commit comments

Comments
 (0)