Skip to content

Commit 14951be

Browse files
stkidwilldeacon
authored andcommitted
arm64: armv8_deprecated: Fix warning in isndep cpuhp starting process
The function run_all_insn_set_hw_mode() is registered as startup callback of 'CPUHP_AP_ARM64_ISNDEP_STARTING', it invokes set_hw_mode() methods of all emulated instructions. As the STARTING callbacks are not expected to fail, if one of the set_hw_mode() fails, e.g. due to el0 mixed-endian is not supported for 'setend', it will report a warning: ``` CPU[2] cannot support the emulation of setend CPU 2 UP state arm64/isndep:starting (136) failed (-22) CPU2: Booted secondary processor 0x0000000002 [0x414fd0c1] ``` To fix it, add a check for INSN_UNAVAILABLE status and skip the process. Signed-off-by: Wei Li <[email protected]> Tested-by: Huisong Li <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Will Deacon <[email protected]>
1 parent c3f38fa commit 14951be

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

arch/arm64/kernel/armv8_deprecated.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -462,6 +462,9 @@ static int run_all_insn_set_hw_mode(unsigned int cpu)
462462
for (int i = 0; i < ARRAY_SIZE(insn_emulations); i++) {
463463
struct insn_emulation *insn = insn_emulations[i];
464464
bool enable = READ_ONCE(insn->current_mode) == INSN_HW;
465+
if (insn->status == INSN_UNAVAILABLE)
466+
continue;
467+
465468
if (insn->set_hw_mode && insn->set_hw_mode(enable)) {
466469
pr_warn("CPU[%u] cannot support the emulation of %s",
467470
cpu, insn->name);

0 commit comments

Comments
 (0)