Skip to content

Commit 14a92fd

Browse files
Alexander Aringteigland
authored andcommitted
dlm: move conversion to compile time
This patch is a cleanup to move the byte order conversion to compile time. In a simple comparison like this it's possible to move it to static values so the compiler will always convert those values at compile time. Signed-off-by: Alexander Aring <[email protected]> Signed-off-by: David Teigland <[email protected]>
1 parent 00e99cc commit 14a92fd

File tree

1 file changed

+10
-10
lines changed

1 file changed

+10
-10
lines changed

fs/dlm/midcomms.c

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -571,14 +571,14 @@ dlm_midcomms_recv_node_lookup(int nodeid, const union dlm_packet *p,
571571
return NULL;
572572
}
573573

574-
switch (le32_to_cpu(p->rcom.rc_type)) {
575-
case DLM_RCOM_NAMES:
574+
switch (p->rcom.rc_type) {
575+
case cpu_to_le32(DLM_RCOM_NAMES):
576576
fallthrough;
577-
case DLM_RCOM_NAMES_REPLY:
577+
case cpu_to_le32(DLM_RCOM_NAMES_REPLY):
578578
fallthrough;
579-
case DLM_RCOM_STATUS:
579+
case cpu_to_le32(DLM_RCOM_STATUS):
580580
fallthrough;
581-
case DLM_RCOM_STATUS_REPLY:
581+
case cpu_to_le32(DLM_RCOM_STATUS_REPLY):
582582
node = nodeid2node(nodeid, 0);
583583
if (node) {
584584
spin_lock(&node->state_lock);
@@ -738,14 +738,14 @@ static void dlm_midcomms_receive_buffer_3_2(union dlm_packet *p, int nodeid)
738738
*
739739
* length already checked.
740740
*/
741-
switch (le32_to_cpu(p->rcom.rc_type)) {
742-
case DLM_RCOM_NAMES:
741+
switch (p->rcom.rc_type) {
742+
case cpu_to_le32(DLM_RCOM_NAMES):
743743
fallthrough;
744-
case DLM_RCOM_NAMES_REPLY:
744+
case cpu_to_le32(DLM_RCOM_NAMES_REPLY):
745745
fallthrough;
746-
case DLM_RCOM_STATUS:
746+
case cpu_to_le32(DLM_RCOM_STATUS):
747747
fallthrough;
748-
case DLM_RCOM_STATUS_REPLY:
748+
case cpu_to_le32(DLM_RCOM_STATUS_REPLY):
749749
break;
750750
default:
751751
log_print("unsupported rcom type received: %u, will skip this message from node %d",

0 commit comments

Comments
 (0)