Skip to content

Commit 14b15ae

Browse files
jamesequinlankwilczynski
authored andcommitted
dt-bindings: PCI: brcmstb: Add property "brcm,clkreq-mode"
The Broadcom STB/CM PCIe HW -- a core that is also used by RPi SOCs -- requires the driver to deliberately place the RC HW one of three CLKREQ# modes. The "brcm,clkreq-mode" property allows the user to override the default setting. If this property is omitted, the default mode shall be "default". Link: https://lore.kernel.org/linux-pci/[email protected] Tested-by: Cyril Brulebois <[email protected]> Tested-by: Florian Fainelli <[email protected]> Signed-off-by: Jim Quinlan <[email protected]> Signed-off-by: Krzysztof Wilczyński <[email protected]> Reviewed-by: Rob Herring <[email protected]> Acked-by: Conor Dooley <[email protected]>
1 parent b85ea95 commit 14b15ae

File tree

1 file changed

+18
-0
lines changed

1 file changed

+18
-0
lines changed

Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,24 @@ properties:
6464

6565
aspm-no-l0s: true
6666

67+
brcm,clkreq-mode:
68+
description: A string that determines the operating
69+
clkreq mode of the PCIe RC HW with respect to controlling the refclk
70+
signal. There are three different modes -- "safe", which drives the
71+
refclk signal unconditionally and will work for all devices but does
72+
not provide any power savings; "no-l1ss" -- which provides Clock
73+
Power Management, L0s, and L1, but cannot provide L1 substate (L1SS)
74+
power savings. If the downstream device connected to the RC is L1SS
75+
capable AND the OS enables L1SS, all PCIe traffic may abruptly halt,
76+
potentially hanging the system; "default" -- which provides L0s, L1,
77+
and L1SS, but not compliant to provide Clock Power Management;
78+
specifically, may not be able to meet the T_CLRon max timing of 400ns
79+
as specified in "Dynamic Clock Control", section 3.2.5.2.2 PCI
80+
Express Mini CEM 2.1 specification. This situation is atypical and
81+
should happen only with older devices.
82+
$ref: /schemas/types.yaml#/definitions/string
83+
enum: [ safe, no-l1ss, default ]
84+
6785
brcm,scb-sizes:
6886
description: u64 giving the 64bit PCIe memory
6987
viewport size of a memory controller. There may be up to

0 commit comments

Comments
 (0)