Skip to content

Commit 150d715

Browse files
committed
futex: Split futex_mm_release() for exit/exec
To allow separate handling of the futex exit state in the futex exit code for exit and exec, split futex_mm_release() into two functions and invoke them from the corresponding exit/exec_mm_release() callsites. Preparatory only, no functional change. Signed-off-by: Thomas Gleixner <[email protected]> Reviewed-by: Ingo Molnar <[email protected]> Acked-by: Peter Zijlstra (Intel) <[email protected]> Link: https://lkml.kernel.org/r/[email protected]
1 parent 4610ba7 commit 150d715

File tree

3 files changed

+12
-6
lines changed

3 files changed

+12
-6
lines changed

include/linux/futex.h

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -93,14 +93,16 @@ static inline void futex_exit_done(struct task_struct *tsk)
9393
tsk->futex_state = FUTEX_STATE_DEAD;
9494
}
9595

96-
void futex_mm_release(struct task_struct *tsk);
96+
void futex_exit_release(struct task_struct *tsk);
97+
void futex_exec_release(struct task_struct *tsk);
9798

9899
long do_futex(u32 __user *uaddr, int op, u32 val, ktime_t *timeout,
99100
u32 __user *uaddr2, u32 val2, u32 val3);
100101
#else
101102
static inline void futex_init_task(struct task_struct *tsk) { }
102-
static inline void futex_mm_release(struct task_struct *tsk) { }
103103
static inline void futex_exit_done(struct task_struct *tsk) { }
104+
static inline void futex_exit_release(struct task_struct *tsk) { }
105+
static inline void futex_exec_release(struct task_struct *tsk) { }
104106
static inline long do_futex(u32 __user *uaddr, int op, u32 val,
105107
ktime_t *timeout, u32 __user *uaddr2,
106108
u32 val2, u32 val3)

kernel/fork.c

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1285,9 +1285,6 @@ static int wait_for_vfork_done(struct task_struct *child,
12851285
*/
12861286
static void mm_release(struct task_struct *tsk, struct mm_struct *mm)
12871287
{
1288-
/* Get rid of any futexes when releasing the mm */
1289-
futex_mm_release(tsk);
1290-
12911288
uprobe_free_utask(tsk);
12921289

12931290
/* Get rid of any cached register state */
@@ -1322,11 +1319,13 @@ static void mm_release(struct task_struct *tsk, struct mm_struct *mm)
13221319

13231320
void exit_mm_release(struct task_struct *tsk, struct mm_struct *mm)
13241321
{
1322+
futex_exit_release(tsk);
13251323
mm_release(tsk, mm);
13261324
}
13271325

13281326
void exec_mm_release(struct task_struct *tsk, struct mm_struct *mm)
13291327
{
1328+
futex_exec_release(tsk);
13301329
mm_release(tsk, mm);
13311330
}
13321331

kernel/futex.c

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3661,7 +3661,7 @@ static void exit_robust_list(struct task_struct *curr)
36613661
}
36623662
}
36633663

3664-
void futex_mm_release(struct task_struct *tsk)
3664+
void futex_exec_release(struct task_struct *tsk)
36653665
{
36663666
if (unlikely(tsk->robust_list)) {
36673667
exit_robust_list(tsk);
@@ -3679,6 +3679,11 @@ void futex_mm_release(struct task_struct *tsk)
36793679
exit_pi_state_list(tsk);
36803680
}
36813681

3682+
void futex_exit_release(struct task_struct *tsk)
3683+
{
3684+
futex_exec_release(tsk);
3685+
}
3686+
36823687
long do_futex(u32 __user *uaddr, int op, u32 val, ktime_t *timeout,
36833688
u32 __user *uaddr2, u32 val2, u32 val3)
36843689
{

0 commit comments

Comments
 (0)