@@ -70,7 +70,8 @@ static struct socket_info sockets[MAX_SOCKETS];
70
70
static int socket_count ; /* shortcut */
71
71
72
72
73
- static int i82092aa_pci_probe (struct pci_dev * dev , const struct pci_device_id * id )
73
+ static int i82092aa_pci_probe (struct pci_dev * dev ,
74
+ const struct pci_device_id * id )
74
75
{
75
76
unsigned char configbyte ;
76
77
int i , ret ;
@@ -81,7 +82,9 @@ static int i82092aa_pci_probe(struct pci_dev *dev, const struct pci_device_id *i
81
82
if (ret )
82
83
return ret ;
83
84
84
- pci_read_config_byte (dev , 0x40 , & configbyte ); /* PCI Configuration Control */
85
+ /* PCI Configuration Control */
86
+ pci_read_config_byte (dev , 0x40 , & configbyte );
87
+
85
88
switch (configbyte & 6 ) {
86
89
case 0 :
87
90
socket_count = 2 ;
@@ -128,9 +131,13 @@ static int i82092aa_pci_probe(struct pci_dev *dev, const struct pci_device_id *i
128
131
}
129
132
}
130
133
131
- /* Now, specifiy that all interrupts are to be done as PCI interrupts */
132
- configbyte = 0xFF ; /* bitmask, one bit per event, 1 = PCI interrupt, 0 = ISA interrupt */
133
- pci_write_config_byte (dev , 0x50 , configbyte ); /* PCI Interrupt Routing Register */
134
+ /* Now, specifiy that all interrupts are to be done as PCI interrupts
135
+ * bitmask, one bit per event, 1 = PCI interrupt, 0 = ISA interrupt
136
+ */
137
+ configbyte = 0xFF ;
138
+
139
+ /* PCI Interrupt Routing Register */
140
+ pci_write_config_byte (dev , 0x50 , configbyte );
134
141
135
142
/* Register the interrupt handler */
136
143
dev_dbg (& dev -> dev , "Requesting interrupt %i\n" , dev -> irq );
@@ -251,7 +258,8 @@ static void indirect_setbit(int socket, unsigned short reg, unsigned char mask)
251
258
}
252
259
253
260
254
- static void indirect_resetbit (int socket , unsigned short reg , unsigned char mask )
261
+ static void indirect_resetbit (int socket ,
262
+ unsigned short reg , unsigned char mask )
255
263
{
256
264
unsigned short int port ;
257
265
unsigned char val ;
@@ -268,7 +276,8 @@ static void indirect_resetbit(int socket, unsigned short reg, unsigned char mask
268
276
spin_unlock_irqrestore (& port_lock , flags );
269
277
}
270
278
271
- static void indirect_write16 (int socket , unsigned short reg , unsigned short value )
279
+ static void indirect_write16 (int socket ,
280
+ unsigned short reg , unsigned short value )
272
281
{
273
282
unsigned short int port ;
274
283
unsigned char val ;
@@ -327,10 +336,12 @@ static irqreturn_t i82092aa_interrupt(int irq, void *dev)
327
336
for (i = 0 ; i < socket_count ; i ++ ) {
328
337
int csc ;
329
338
330
- if (sockets [i ].card_state == 0 ) /* Inactive socket, should not happen */
339
+ /* Inactive socket, should not happen */
340
+ if (sockets [i ].card_state == 0 )
331
341
continue ;
332
342
333
- csc = indirect_read (i , I365_CSC ); /* card status change register */
343
+ /* card status change register */
344
+ csc = indirect_read (i , I365_CSC );
334
345
335
346
if (csc == 0 ) /* no events on this socket */
336
347
continue ;
@@ -345,12 +356,16 @@ static irqreturn_t i82092aa_interrupt(int irq, void *dev)
345
356
346
357
if (indirect_read (i , I365_INTCTL ) & I365_PC_IOCARD ) {
347
358
/* For IO/CARDS, bit 0 means "read the card" */
348
- events |= (csc & I365_CSC_STSCHG ) ? SS_STSCHG : 0 ;
359
+ if (csc & I365_CSC_STSCHG )
360
+ events |= SS_STSCHG ;
349
361
} else {
350
362
/* Check for battery/ready events */
351
- events |= (csc & I365_CSC_BVD1 ) ? SS_BATDEAD : 0 ;
352
- events |= (csc & I365_CSC_BVD2 ) ? SS_BATWARN : 0 ;
353
- events |= (csc & I365_CSC_READY ) ? SS_READY : 0 ;
363
+ if (csc & I365_CSC_BVD1 )
364
+ events |= SS_BATDEAD ;
365
+ if (csc & I365_CSC_BVD2 )
366
+ events |= SS_BATWARN ;
367
+ if (csc & I365_CSC_READY )
368
+ events |= SS_READY ;
354
369
}
355
370
356
371
if (events )
@@ -426,12 +441,15 @@ static int i82092aa_init(struct pcmcia_socket *sock)
426
441
427
442
static int i82092aa_get_status (struct pcmcia_socket * socket , u_int * value )
428
443
{
429
- unsigned int sock = container_of (socket , struct socket_info , socket )-> number ;
444
+ unsigned int sock = container_of (socket ,
445
+ struct socket_info , socket )-> number ;
430
446
unsigned int status ;
431
447
432
448
enter ("i82092aa_get_status" );
433
-
434
- status = indirect_read (sock , I365_STATUS ); /* Interface Status Register */
449
+
450
+ /* Interface Status Register */
451
+ status = indirect_read (sock , I365_STATUS );
452
+
435
453
* value = 0 ;
436
454
437
455
if ((status & I365_CS_DETECT ) == I365_CS_DETECT )
@@ -464,7 +482,8 @@ static int i82092aa_get_status(struct pcmcia_socket *socket, u_int *value)
464
482
}
465
483
466
484
467
- static int i82092aa_set_socket (struct pcmcia_socket * socket , socket_state_t * state )
485
+ static int i82092aa_set_socket (struct pcmcia_socket * socket ,
486
+ socket_state_t * state )
468
487
{
469
488
struct socket_info * sock_info = container_of (socket , struct socket_info ,
470
489
socket );
@@ -480,12 +499,15 @@ static int i82092aa_set_socket(struct pcmcia_socket *socket, socket_state_t *sta
480
499
/* Values for the IGENC register */
481
500
482
501
reg = 0 ;
483
- if (!(state -> flags & SS_RESET )) /* The reset bit has "inverse" logic */
502
+
503
+ /* The reset bit has "inverse" logic */
504
+ if (!(state -> flags & SS_RESET ))
484
505
reg = reg | I365_PC_RESET ;
485
506
if (state -> flags & SS_IOCARD )
486
507
reg = reg | I365_PC_IOCARD ;
487
508
488
- indirect_write (sock , I365_INTCTL , reg ); /* IGENC, Interrupt and General Control Register */
509
+ /* IGENC, Interrupt and General Control Register */
510
+ indirect_write (sock , I365_INTCTL , reg );
489
511
490
512
/* Power registers */
491
513
@@ -560,7 +582,9 @@ static int i82092aa_set_socket(struct pcmcia_socket *socket, socket_state_t *sta
560
582
561
583
}
562
584
563
- /* now write the value and clear the (probably bogus) pending stuff by doing a dummy read*/
585
+ /* now write the value and clear the (probably bogus) pending stuff
586
+ * by doing a dummy read
587
+ */
564
588
565
589
indirect_write (sock , I365_CSCINT , reg );
566
590
(void )indirect_read (sock , I365_CSC );
@@ -569,7 +593,8 @@ static int i82092aa_set_socket(struct pcmcia_socket *socket, socket_state_t *sta
569
593
return 0 ;
570
594
}
571
595
572
- static int i82092aa_set_io_map (struct pcmcia_socket * socket , struct pccard_io_map * io )
596
+ static int i82092aa_set_io_map (struct pcmcia_socket * socket ,
597
+ struct pccard_io_map * io )
573
598
{
574
599
struct socket_info * sock_info = container_of (socket , struct socket_info ,
575
600
socket );
@@ -585,7 +610,8 @@ static int i82092aa_set_io_map(struct pcmcia_socket *socket, struct pccard_io_ma
585
610
leave ("i82092aa_set_io_map with invalid map" );
586
611
return - EINVAL ;
587
612
}
588
- if ((io -> start > 0xffff ) || (io -> stop > 0xffff ) || (io -> stop < io -> start )) {
613
+ if ((io -> start > 0xffff ) || (io -> stop > 0xffff )
614
+ || (io -> stop < io -> start )) {
589
615
leave ("i82092aa_set_io_map with invalid io" );
590
616
return - EINVAL ;
591
617
}
@@ -613,9 +639,11 @@ static int i82092aa_set_io_map(struct pcmcia_socket *socket, struct pccard_io_ma
613
639
return 0 ;
614
640
}
615
641
616
- static int i82092aa_set_mem_map (struct pcmcia_socket * socket , struct pccard_mem_map * mem )
642
+ static int i82092aa_set_mem_map (struct pcmcia_socket * socket ,
643
+ struct pccard_mem_map * mem )
617
644
{
618
- struct socket_info * sock_info = container_of (socket , struct socket_info , socket );
645
+ struct socket_info * sock_info = container_of (socket , struct socket_info ,
646
+ socket );
619
647
unsigned int sock = sock_info -> number ;
620
648
struct pci_bus_region region ;
621
649
unsigned short base , i ;
@@ -636,8 +664,7 @@ static int i82092aa_set_mem_map(struct pcmcia_socket *socket, struct pccard_mem_
636
664
(mem -> speed > 1000 )) {
637
665
leave ("i82092aa_set_mem_map: invalid address / speed" );
638
666
dev_err (& sock_info -> dev -> dev ,
639
- "invalid mem map for socket %i: %llx to %llx with a "
640
- "start of %x\n" ,
667
+ "invalid mem map for socket %i: %llx to %llx with a start of %x\n" ,
641
668
sock ,
642
669
(unsigned long long )region .start ,
643
670
(unsigned long long )region .end ,
0 commit comments