Skip to content

Commit 152d394

Browse files
jhovoldAbhinav Kumar
authored andcommitted
drm/msm/hdmi: fix IRQ lifetime
Device-managed resources allocated post component bind must be tied to the lifetime of the aggregate DRM device or they will not necessarily be released when binding of the aggregate device is deferred. This is specifically true for the HDMI IRQ, which will otherwise remain requested so that the next bind attempt fails when requesting the IRQ a second time. Fix this by tying the device-managed lifetime of the HDMI IRQ to the DRM device so that it is released when bind fails. Fixes: 067fef3 ("drm/msm/hdmi: refactor bind/init") Cc: [email protected] # 3.19 Reviewed-by: Dmitry Baryshkov <[email protected]> Signed-off-by: Johan Hovold <[email protected]> Tested-by: Kuogee Hsieh <[email protected]> Reviewed-by: Kuogee Hsieh <[email protected]> Patchwork: https://patchwork.freedesktop.org/patch/502666/ Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Abhinav Kumar <[email protected]>
1 parent 1619495 commit 152d394

File tree

1 file changed

+1
-1
lines changed
  • drivers/gpu/drm/msm/hdmi

1 file changed

+1
-1
lines changed

drivers/gpu/drm/msm/hdmi/hdmi.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -344,7 +344,7 @@ int msm_hdmi_modeset_init(struct hdmi *hdmi,
344344
goto fail;
345345
}
346346

347-
ret = devm_request_irq(&pdev->dev, hdmi->irq,
347+
ret = devm_request_irq(dev->dev, hdmi->irq,
348348
msm_hdmi_irq, IRQF_TRIGGER_HIGH,
349349
"hdmi_isr", hdmi);
350350
if (ret < 0) {

0 commit comments

Comments
 (0)