Skip to content

Commit 153031a

Browse files
cengiz-ioaxboe
authored andcommitted
blktrace: fix dereference after null check
There was a recent change in blktrace.c that added a RCU protection to `q->blk_trace` in order to fix a use-after-free issue during access. However the change missed an edge case that can lead to dereferencing of `bt` pointer even when it's NULL: Coverity static analyzer marked this as a FORWARD_NULL issue with CID 1460458. ``` /kernel/trace/blktrace.c: 1904 in sysfs_blk_trace_attr_store() 1898 ret = 0; 1899 if (bt == NULL) 1900 ret = blk_trace_setup_queue(q, bdev); 1901 1902 if (ret == 0) { 1903 if (attr == &dev_attr_act_mask) >>> CID 1460458: Null pointer dereferences (FORWARD_NULL) >>> Dereferencing null pointer "bt". 1904 bt->act_mask = value; 1905 else if (attr == &dev_attr_pid) 1906 bt->pid = value; 1907 else if (attr == &dev_attr_start_lba) 1908 bt->start_lba = value; 1909 else if (attr == &dev_attr_end_lba) ``` Added a reassignment with RCU annotation to fix the issue. Fixes: c780e86 ("blktrace: Protect q->blk_trace with RCU") Cc: [email protected] Reviewed-by: Ming Lei <[email protected]> Reviewed-by: Bob Liu <[email protected]> Reviewed-by: Steven Rostedt (VMware) <[email protected]> Signed-off-by: Cengiz Can <[email protected]> Signed-off-by: Jens Axboe <[email protected]>
1 parent 764b53b commit 153031a

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

kernel/trace/blktrace.c

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1896,8 +1896,11 @@ static ssize_t sysfs_blk_trace_attr_store(struct device *dev,
18961896
}
18971897

18981898
ret = 0;
1899-
if (bt == NULL)
1899+
if (bt == NULL) {
19001900
ret = blk_trace_setup_queue(q, bdev);
1901+
bt = rcu_dereference_protected(q->blk_trace,
1902+
lockdep_is_held(&q->blk_trace_mutex));
1903+
}
19011904

19021905
if (ret == 0) {
19031906
if (attr == &dev_attr_act_mask)

0 commit comments

Comments
 (0)