Skip to content

Commit 1595fe2

Browse files
committed
Revert "arm64: kexec: make dtb_mem always enabled"
Adding crash dump support to 'kexec_file' is going to extend 'struct kimage_arch' with more 'kexec_file'-specific members. The cleanup here then starts to get in the way, so revert it. This reverts commit 6215167. Reported-by: AKASHI Takahiro <[email protected]> Signed-off-by: Will Deacon <[email protected]>
1 parent a2c2e67 commit 1595fe2

File tree

2 files changed

+7
-3
lines changed

2 files changed

+7
-3
lines changed

arch/arm64/include/asm/kexec.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -90,14 +90,14 @@ static inline void crash_prepare_suspend(void) {}
9090
static inline void crash_post_resume(void) {}
9191
#endif
9292

93+
#ifdef CONFIG_KEXEC_FILE
9394
#define ARCH_HAS_KIMAGE_ARCH
9495

9596
struct kimage_arch {
9697
void *dtb;
97-
phys_addr_t dtb_mem;
98+
unsigned long dtb_mem;
9899
};
99100

100-
#ifdef CONFIG_KEXEC_FILE
101101
extern const struct kexec_file_ops kexec_image_ops;
102102

103103
struct kimage;

arch/arm64/kernel/machine_kexec.c

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -203,7 +203,11 @@ void machine_kexec(struct kimage *kimage)
203203
* In kexec_file case, the kernel starts directly without purgatory.
204204
*/
205205
cpu_soft_restart(reboot_code_buffer_phys, kimage->head, kimage->start,
206-
kimage->arch.dtb_mem);
206+
#ifdef CONFIG_KEXEC_FILE
207+
kimage->arch.dtb_mem);
208+
#else
209+
0);
210+
#endif
207211

208212
BUG(); /* Should never get here. */
209213
}

0 commit comments

Comments
 (0)