Skip to content

Commit 15b413d

Browse files
VARoDeKbroonie
authored andcommitted
spi: spi-topcliff-pch: drop call to wakeup-disable
Before generic upgrade, both .suspend() and .resume() were invoking pci_enable_wake(pci_dev, PCI_D3hot, 0). Hence, disabling wakeup in both states. (Normal trend is .suspend() enables and .resume() disables the wakeup.) This was ambiguous and may be buggy. Instead of replicating the legacy behavior, drop the wakeup-disable call. Fixes: f185bcc ("spi: spi-topcliff-pch: use generic power management") Reported-by: Andy Shevchenko <[email protected]> Signed-off-by: Vaibhav Gupta <[email protected]> Reviewed-by: Andy Shevchenko <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Mark Brown <[email protected]>
1 parent aa9e862 commit 15b413d

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed

drivers/spi/spi-topcliff-pch.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1652,8 +1652,6 @@ static int __maybe_unused pch_spi_resume(struct device *dev)
16521652

16531653
dev_dbg(dev, "%s ENTRY\n", __func__);
16541654

1655-
device_wakeup_disable(dev);
1656-
16571655
/* set suspend status to false */
16581656
pd_dev_save->board_dat->suspend_sts = false;
16591657

0 commit comments

Comments
 (0)