Skip to content

Commit 162e068

Browse files
Anuj Guptaaxboe
authored andcommitted
block: t10-pi: Return correct ref tag when queue has no integrity profile
Commit c6e56cf ("block: move integrity information into queue_limits") changed the ref tag calculation logic. It would break if there is no integrity profile. This in turn causes read/write failures for such cases. Fixes: c6e56cf ("block: move integrity information into queue_limits") Signed-off-by: Anuj Gupta <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Jens Axboe <[email protected]>
1 parent 98d34c0 commit 162e068

File tree

1 file changed

+8
-2
lines changed

1 file changed

+8
-2
lines changed

include/linux/t10-pi.h

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,11 @@ struct t10_pi_tuple {
3939

4040
static inline u32 t10_pi_ref_tag(struct request *rq)
4141
{
42-
unsigned int shift = rq->q->limits.integrity.interval_exp;
42+
unsigned int shift = ilog2(queue_logical_block_size(rq->q));
4343

44+
if (IS_ENABLED(CONFIG_BLK_DEV_INTEGRITY) &&
45+
rq->q->limits.integrity.interval_exp)
46+
shift = rq->q->limits.integrity.interval_exp;
4447
return blk_rq_pos(rq) >> (shift - SECTOR_SHIFT) & 0xffffffff;
4548
}
4649

@@ -61,8 +64,11 @@ static inline u64 lower_48_bits(u64 n)
6164

6265
static inline u64 ext_pi_ref_tag(struct request *rq)
6366
{
64-
unsigned int shift = rq->q->limits.integrity.interval_exp;
67+
unsigned int shift = ilog2(queue_logical_block_size(rq->q));
6568

69+
if (IS_ENABLED(CONFIG_BLK_DEV_INTEGRITY) &&
70+
rq->q->limits.integrity.interval_exp)
71+
shift = rq->q->limits.integrity.interval_exp;
6672
return lower_48_bits(blk_rq_pos(rq) >> (shift - SECTOR_SHIFT));
6773
}
6874

0 commit comments

Comments
 (0)