Skip to content

Commit 1630146

Browse files
geertuJonathan Corbet
authored andcommitted
scripts/find-unused-docs: Fix massive false positives
scripts/find-unused-docs.sh invokes scripts/kernel-doc to find out if a source file contains kerneldoc or not. However, as it passes the no longer supported "-text" option to scripts/kernel-doc, the latter prints out its help text, causing all files to be considered containing kerneldoc. Get rid of these false positives by removing the no longer supported "-text" option from the scripts/kernel-doc invocation. Cc: [email protected] # 4.16+ Fixes: b051426 ("scripts: kernel-doc: get rid of unused output formats") Signed-off-by: Geert Uytterhoeven <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Jonathan Corbet <[email protected]>
1 parent 06b9c26 commit 1630146

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

scripts/find-unused-docs.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ for file in `find $1 -name '*.c'`; do
5454
if [[ ${FILES_INCLUDED[$file]+_} ]]; then
5555
continue;
5656
fi
57-
str=$(scripts/kernel-doc -text -export "$file" 2>/dev/null)
57+
str=$(scripts/kernel-doc -export "$file" 2>/dev/null)
5858
if [[ -n "$str" ]]; then
5959
echo "$file"
6060
fi

0 commit comments

Comments
 (0)