Skip to content

Commit 164c4ac

Browse files
ukleinekUwe Kleine-König
authored andcommitted
pwm: Let pwm_set_waveform_might_sleep() return 0 instead of 1 after rounding up
While telling the caller of pwm_set_waveform_might_sleep() if the request was completed by rounding down only or (some) rounding up gives additional information, it makes usage this function needlessly hard and the additional information is not used. A prove for that is that currently both users of this function just pass the returned value up to their caller even though a positive value isn't intended there. Signed-off-by: Uwe Kleine-König <[email protected]> Link: https://lore.kernel.org/r/528cc3bbd9e35dea8646b1bcc0fbfe6c498bb4ed.1746010245.git.u.kleine-koenig@baylibre.com Signed-off-by: Uwe Kleine-König <[email protected]>
1 parent e866834 commit 164c4ac

File tree

1 file changed

+8
-6
lines changed

1 file changed

+8
-6
lines changed

drivers/pwm/core.c

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -411,9 +411,8 @@ static int __pwm_set_waveform(struct pwm_device *pwm,
411411
* possible/needed. In the above example requesting .period_length_ns = 94 and
412412
* @exact = true, you get the hardware configured with period = 93.5 ns.
413413
*
414-
* Returns: 0 on success, 1 if was rounded up (if !@exact), -EDOM if setting
415-
* failed due to the exact waveform not being possible (if @exact), or a
416-
* different negative errno on failure.
414+
* Returns: 0 on success, -EDOM if setting failed due to the exact waveform not
415+
* being possible (if @exact), or a different negative errno on failure.
417416
* Context: May sleep.
418417
*/
419418
int pwm_set_waveform_might_sleep(struct pwm_device *pwm,
@@ -442,14 +441,17 @@ int pwm_set_waveform_might_sleep(struct pwm_device *pwm,
442441
}
443442

444443
/*
445-
* map err == 1 to -EDOM for exact requests. Also make sure that -EDOM is
446-
* only returned in exactly that case. Note that __pwm_set_waveform()
447-
* should never return -EDOM which justifies the unlikely().
444+
* map err == 1 to -EDOM for exact requests and 0 for !exact ones. Also
445+
* make sure that -EDOM is only returned in exactly that case. Note that
446+
* __pwm_set_waveform() should never return -EDOM which justifies the
447+
* unlikely().
448448
*/
449449
if (unlikely(err == -EDOM))
450450
err = -EINVAL;
451451
else if (exact && err == 1)
452452
err = -EDOM;
453+
else if (err == 1)
454+
err = 0;
453455

454456
return err;
455457
}

0 commit comments

Comments
 (0)