Skip to content

Commit 167ec66

Browse files
nxpfranklivinodkoul
authored andcommitted
dt-bindings: dma: fsl-edma: allow 'power-domains' property
Allow 'power-domains' property because i.MX8DXL i.MX8QM and i.MX8QXP need it. EDMA supports each power-domain for each dma channel. So minItems and maxItems align 'dma-channels'. Change fsl,imx93-edma3 example to fsl,imx8qm-edma to reflect this variants. Fixed below DTB_CHECK warning: dma-controller@599f0000: Unevaluated properties are not allowed ('power-domains' was unexpected) Signed-off-by: Frank Li <[email protected]> Reviewed-by: Rob Herring (Arm) <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Vinod Koul <[email protected]>
1 parent 9c21bbf commit 167ec66

File tree

1 file changed

+42
-38
lines changed

1 file changed

+42
-38
lines changed

Documentation/devicetree/bindings/dma/fsl,edma.yaml

Lines changed: 42 additions & 38 deletions
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,13 @@ properties:
7070
minItems: 1
7171
maxItems: 33
7272

73+
power-domains:
74+
description:
75+
The number of power domains matches the number of channels, arranged
76+
in ascending order according to their associated DMA channels.
77+
minItems: 1
78+
maxItems: 64
79+
7380
big-endian:
7481
description: |
7582
If present registers and hardware scatter/gather descriptors of the
@@ -200,6 +207,20 @@ allOf:
200207
required:
201208
- clocks
202209

210+
- if:
211+
properties:
212+
compatible:
213+
contains:
214+
enum:
215+
- fsl,imx8qm-adma
216+
- fsl,imx8qm-edma
217+
then:
218+
required:
219+
- power-domains
220+
else:
221+
properties:
222+
power-domains: false
223+
203224
unevaluatedProperties: false
204225

205226
examples:
@@ -255,44 +276,27 @@ examples:
255276
256277
- |
257278
#include <dt-bindings/interrupt-controller/arm-gic.h>
258-
#include <dt-bindings/clock/imx93-clock.h>
279+
#include <dt-bindings/firmware/imx/rsrc.h>
259280
260-
dma-controller@44000000 {
261-
compatible = "fsl,imx93-edma3";
262-
reg = <0x44000000 0x200000>;
281+
dma-controller@5a9f0000 {
282+
compatible = "fsl,imx8qm-edma";
283+
reg = <0x5a9f0000 0x90000>;
263284
#dma-cells = <3>;
264-
dma-channels = <31>;
265-
interrupts = <GIC_SPI 95 IRQ_TYPE_LEVEL_HIGH>,
266-
<GIC_SPI 96 IRQ_TYPE_LEVEL_HIGH>,
267-
<GIC_SPI 97 IRQ_TYPE_LEVEL_HIGH>,
268-
<GIC_SPI 98 IRQ_TYPE_LEVEL_HIGH>,
269-
<GIC_SPI 99 IRQ_TYPE_LEVEL_HIGH>,
270-
<GIC_SPI 100 IRQ_TYPE_LEVEL_HIGH>,
271-
<GIC_SPI 101 IRQ_TYPE_LEVEL_HIGH>,
272-
<GIC_SPI 102 IRQ_TYPE_LEVEL_HIGH>,
273-
<GIC_SPI 103 IRQ_TYPE_LEVEL_HIGH>,
274-
<GIC_SPI 104 IRQ_TYPE_LEVEL_HIGH>,
275-
<GIC_SPI 105 IRQ_TYPE_LEVEL_HIGH>,
276-
<GIC_SPI 106 IRQ_TYPE_LEVEL_HIGH>,
277-
<GIC_SPI 107 IRQ_TYPE_LEVEL_HIGH>,
278-
<GIC_SPI 108 IRQ_TYPE_LEVEL_HIGH>,
279-
<GIC_SPI 109 IRQ_TYPE_LEVEL_HIGH>,
280-
<GIC_SPI 110 IRQ_TYPE_LEVEL_HIGH>,
281-
<GIC_SPI 111 IRQ_TYPE_LEVEL_HIGH>,
282-
<GIC_SPI 112 IRQ_TYPE_LEVEL_HIGH>,
283-
<GIC_SPI 113 IRQ_TYPE_LEVEL_HIGH>,
284-
<GIC_SPI 114 IRQ_TYPE_LEVEL_HIGH>,
285-
<GIC_SPI 115 IRQ_TYPE_LEVEL_HIGH>,
286-
<GIC_SPI 116 IRQ_TYPE_LEVEL_HIGH>,
287-
<GIC_SPI 117 IRQ_TYPE_LEVEL_HIGH>,
288-
<GIC_SPI 118 IRQ_TYPE_LEVEL_HIGH>,
289-
<GIC_SPI 119 IRQ_TYPE_LEVEL_HIGH>,
290-
<GIC_SPI 120 IRQ_TYPE_LEVEL_HIGH>,
291-
<GIC_SPI 121 IRQ_TYPE_LEVEL_HIGH>,
292-
<GIC_SPI 122 IRQ_TYPE_LEVEL_HIGH>,
293-
<GIC_SPI 123 IRQ_TYPE_LEVEL_HIGH>,
294-
<GIC_SPI 124 IRQ_TYPE_LEVEL_HIGH>,
295-
<GIC_SPI 125 IRQ_TYPE_LEVEL_HIGH>;
296-
clocks = <&clk IMX93_CLK_EDMA1_GATE>;
297-
clock-names = "dma";
285+
dma-channels = <8>;
286+
interrupts = <GIC_SPI 424 IRQ_TYPE_LEVEL_HIGH>,
287+
<GIC_SPI 425 IRQ_TYPE_LEVEL_HIGH>,
288+
<GIC_SPI 426 IRQ_TYPE_LEVEL_HIGH>,
289+
<GIC_SPI 427 IRQ_TYPE_LEVEL_HIGH>,
290+
<GIC_SPI 428 IRQ_TYPE_LEVEL_HIGH>,
291+
<GIC_SPI 429 IRQ_TYPE_LEVEL_HIGH>,
292+
<GIC_SPI 430 IRQ_TYPE_LEVEL_HIGH>,
293+
<GIC_SPI 431 IRQ_TYPE_LEVEL_HIGH>;
294+
power-domains = <&pd IMX_SC_R_DMA_3_CH0>,
295+
<&pd IMX_SC_R_DMA_3_CH1>,
296+
<&pd IMX_SC_R_DMA_3_CH2>,
297+
<&pd IMX_SC_R_DMA_3_CH3>,
298+
<&pd IMX_SC_R_DMA_3_CH4>,
299+
<&pd IMX_SC_R_DMA_3_CH5>,
300+
<&pd IMX_SC_R_DMA_3_CH6>,
301+
<&pd IMX_SC_R_DMA_3_CH7>;
298302
};

0 commit comments

Comments
 (0)