Skip to content

Commit 1680939

Browse files
HBh25Ymathieupoirier
authored andcommitted
rpmsg: virtio: Fix possible double free in rpmsg_virtio_add_ctrl_dev()
vch will be free in virtio_rpmsg_release_device() when rpmsg_ctrldev_register_device() fails. There is no need to call kfree() again. Fixes: c486682 ("rpmsg: virtio: Register the rpmsg_char device") Signed-off-by: Hangyu Hua <[email protected]> Tested-by: Arnaud Pouliquen <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Mathieu Poirier <[email protected]>
1 parent c2eecef commit 1680939

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/rpmsg/virtio_rpmsg_bus.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -851,7 +851,7 @@ static struct rpmsg_device *rpmsg_virtio_add_ctrl_dev(struct virtio_device *vdev
851851

852852
err = rpmsg_ctrldev_register_device(rpdev_ctrl);
853853
if (err) {
854-
kfree(vch);
854+
/* vch will be free in virtio_rpmsg_release_device() */
855855
return ERR_PTR(err);
856856
}
857857

0 commit comments

Comments
 (0)