Skip to content

Commit 16a0a69

Browse files
Jinjie Ruankhilman
authored andcommitted
soc: ti: smartreflex: Use IRQF_NO_AUTOEN flag in request_irq()
If request_irq() fails in sr_late_init(), there is no need to enable the irq, and if it succeeds, disable_irq() after request_irq() still has a time gap in which interrupts can come. request_irq() with IRQF_NO_AUTOEN flag will disable IRQ auto-enable when request IRQ. Fixes: 1279ba5 ("OMAP3+: SR: disable interrupt by default") Signed-off-by: Jinjie Ruan <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Kevin Hilman <[email protected]>
1 parent 9852d85 commit 16a0a69

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

drivers/soc/ti/smartreflex.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -202,10 +202,10 @@ static int sr_late_init(struct omap_sr *sr_info)
202202

203203
if (sr_class->notify && sr_class->notify_flags && sr_info->irq) {
204204
ret = devm_request_irq(&sr_info->pdev->dev, sr_info->irq,
205-
sr_interrupt, 0, sr_info->name, sr_info);
205+
sr_interrupt, IRQF_NO_AUTOEN,
206+
sr_info->name, sr_info);
206207
if (ret)
207208
goto error;
208-
disable_irq(sr_info->irq);
209209
}
210210

211211
return ret;

0 commit comments

Comments
 (0)