Skip to content

Commit 16f1f83

Browse files
committed
Revert "ALSA: usb-audio: Drop superfluous interface setup at parsing"
This reverts commit ac5e2fb. The commit caused a regression on Behringer UMC404HD (and likely others). As the change was meant only as a minor optimization, it's better to revert it to address the regression. Reported-and-tested-by: Michael Ralston <[email protected]> Cc: <[email protected]> Link: https://lore.kernel.org/r/CAC2975JXkS1A5Tj9b02G_sy25ZWN-ys+tc9wmkoS=qPgKCogSg@mail.gmail.com Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Takashi Iwai <[email protected]>
1 parent 37b3e56 commit 16f1f83

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

sound/usb/stream.c

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1222,6 +1222,12 @@ static int __snd_usb_parse_audio_interface(struct snd_usb_audio *chip,
12221222
if (err < 0)
12231223
return err;
12241224
}
1225+
1226+
/* try to set the interface... */
1227+
usb_set_interface(chip->dev, iface_no, 0);
1228+
snd_usb_init_pitch(chip, fp);
1229+
snd_usb_init_sample_rate(chip, fp, fp->rate_max);
1230+
usb_set_interface(chip->dev, iface_no, altno);
12251231
}
12261232
return 0;
12271233
}

0 commit comments

Comments
 (0)